fix(tasks): avoid redundant terminal history fetches#3744
Merged
Conversation
Generated-By: PostHog Code Task-Id: a9c061a3-575e-42c6-815e-c0b6edd4b846
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
tatoalo
marked this pull request as ready for review
July 23, 2026 09:33
Contributor
|
Reviews (1): Last reviewed commit: "fix(tasks): avoid redundant terminal his..." | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Contained single-file fix to session log hydration logic (no auth/billing/CI/dependency/migration surface); author has STRONG familiarity with this exact code and Greptile's automated review raised no concerns.
- Author wrote 100% of the modified lines and has 15 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 122L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (122L, 1F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ ac15077 · reviewed head 1f4120c |
tatoalo
enabled auto-merge (squash)
July 23, 2026 09:47
tatoalo
added a commit
that referenced
this pull request
Jul 23, 2026
Main's #3744 (avoid redundant terminal history fetches) made a terminal resume-chain hydration issue one whole-chain fetch instead of an ancestor+current pair, so the expected call count after the terminal watch drops from 4 to 3. The regression the test pins is unchanged: the terminal hydration must start its own fetch rather than dedupe onto the in-flight resume-chain hydration (count would stay 2 if mode-keying broke). Generated-By: PostHog Code Task-Id: 0c511836-2180-455a-9b58-45df2a0661ec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a completed task with a long resume chain downloads overlapping history multiple times before the conversation can render.
Changes
Completed resumed runs now hydrate from the combined session-log response once. Run markers still preserve the leaf boundary used for transcript positioning and counts. Active runs keep the existing reconciliation path.