fix(agent): preserve messages until send succeeds#3766
Merged
Conversation
|
😎 Merged successfully - details. |
tatoalo
added
the
Stamphog
tatoalo
force-pushed
the
posthog-code/preserve-failed-message
branch
from
July 23, 2026 16:14
9dbd327 to
b27454c
Compare
tatoalo
changed the title
tatoalo
marked this pull request as ready for review
July 23, 2026 16:15
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
packages/ui/src/features/sessions/components/SessionView.tsx:320-321
**Successful send clears newer draft**
When a user starts typing the next message while the previous request is pending, the successful-send path unconditionally clears the live editor, erasing the newer message and its saved draft.
### Issue 2 of 2
packages/ui/src/features/sessions/components/SessionView.tsx:315-318
**State guard permits duplicate sends**
When two submission events occur before React commits the first state update, both callbacks read `isSendingPrompt` as false and start a request, causing duplicate agent prompts or a duplicate queued message.
Reviews (1): Last reviewed commit: "fix(agent): preserve messages until send..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
stamphog
Bot
removed
the
Stamphog
tatoalo
force-pushed
the
posthog-code/preserve-failed-message
branch
from
July 23, 2026 16:24
84a2384 to
427da82
Compare
tatoalo
added
the
Stamphog
PostHog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Low-risk UI fix to composer clear/resend logic; the two Greptile P1 concerns (duplicate sends, clearing a newer draft) are both visibly addressed in the diff via the sync ref lock and content-comparison guard, and Greptile reacted 👍 to the fixes. Test coverage added for the failed-send path.
- Author wrote 0% of the modified lines and has 10 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 46L, 2F substantive, 64L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (64L, 3F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 72fff49 · reviewed head 427da82 |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
tatoalo
enabled auto-merge (squash)
July 23, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A failed message request can clear the composer before the server acknowledges it, leaving users without the text they attempted to send.
Changes
Keep composer content in place while a message is being sent. Disable repeat submission during the request and clear the composer only after a successful acknowledgement.