-
Notifications
You must be signed in to change notification settings - Fork 8
test: lock iOS source-map skill contract #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−3
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
54a4353
test: lock iOS source-map skill contract
ablaszkiewicz f5e0a83
feat: document iOS xcconfig credential flow for source-map upload
ablaszkiewicz 88a8b12
feat: pin the verified iOS dSYM upload pipeline in the source-maps skill
ablaszkiewicz 2e42624
feat: pin xcconfig chaining direction and credential-fallback traps f…
ablaszkiewicz f309fb2
refactor: slim the iOS source-maps guidance to a minimal shell
ablaszkiewicz 5296059
fix: iOS local test is one Xcode step, not a CLI/GUI mix
ablaszkiewicz a012d1d
fix: tie POSTHOG_INCLUDE_SOURCE=1 to its failure symptom
ablaszkiewicz 2ba7c3d
refactor: trim include-source note to one clause
ablaszkiewicz 19a959a
refactor: mandate the include-source prefix on the snippet itself
ablaszkiewicz a4736d2
refactor: minimal iOS shell — all creds in one xcconfig, no fallbacks
ablaszkiewicz d0c790a
fix: include-source flag lives in the xcconfig; fileRef in the root g…
ablaszkiewicz 3eb8fc3
revert: include-source stays an inline prefix on the invocation
ablaszkiewicz 1d03ec5
feat(ios): credentials move from xcconfig to gitignored .env
ablaszkiewicz 6ae2731
fix(ios): dotenv path rides POSTHOG_CLI_DOTENV_FILE, read by the CLI …
ablaszkiewicz e6ca679
chore(ios): drop redundant trailer after the test-snippet
ablaszkiewicz 994d1da
fix: move stuff to context mill
ablaszkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
scripts/lib/tests/error-tracking-upload-source-maps.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { join } from 'path'; | ||
|
|
||
| import { expandSkillGroups, loadSkillsConfig } from '../skill-generator.js'; | ||
|
|
||
| const CONFIG_DIR = join(process.cwd(), 'context'); | ||
|
|
||
| describe('error-tracking-upload-source-maps iOS variant', () => { | ||
| it('expands to the skill contract consumed by the wizard', () => { | ||
| const config = loadSkillsConfig(CONFIG_DIR); | ||
| const skills = expandSkillGroups(config, CONFIG_DIR); | ||
| const ios = skills.find((skill) => skill.id === 'error-tracking-upload-source-maps-ios'); | ||
|
|
||
| expect(ios).toMatchObject({ | ||
| id: 'error-tracking-upload-source-maps-ios', | ||
| _shortId: 'ios', | ||
| _category: 'error-tracking-upload-source-maps', | ||
| _group: 'error-tracking-upload-source-maps', | ||
| display_name: 'iOS', | ||
| description: 'Upload dSYM debug symbols to PostHog Error Tracking for iOS', | ||
| tags: ['error-tracking', 'source-maps', 'ios', 'swift'], | ||
| docs_urls: ['https://posthog.com/docs/error-tracking/upload-source-maps/ios.md'], | ||
| _sharedDocs: [ | ||
| 'https://posthog.com/docs/error-tracking/upload-source-maps.md', | ||
| 'https://posthog.com/docs/error-tracking/upload-source-maps/cli.md', | ||
| ], | ||
| _cli: null, | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be time to use variants, I think this will turn to noise and poison your prompts as this list grows.
You can also do this later, it's a larger change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you pulling in docs at all, you should:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using docs and this is all in the docs but I had to add this here explicitly or agent was just lost sometimes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops one thing is not mentioned in the docs. New env variable for dotenv file for the CLI. But agent got lost at cocoa vs SPM and how to properly set the command.
I had to do TONS of back and forth with experimenting with what to put in the context for the agent to finally understand that