fix: make flags retry count configurable

Author: marandaneto

.changeset/quiet-flags-retry.md

@@ -2,4 +2,4 @@
 'PostHog': patch
 ---
 
-Retry feature flag requests after transient network errors only.
+Retry feature flag requests after transient network errors only. The feature flag request retry count defaults to 1 and can be set to 0 to disable retries.

src/PostHog/Config/PostHogOptions.cs

@@ -173,6 +173,12 @@ public string? ProjectApiKey
     /// </remarks>
     public int MaxRetries { get; set; } = 3;
 
+    /// <summary>
+    /// The maximum number of retries for feature flag requests after transient network errors. (Default: 1)
+    /// Set to 0 to disable feature flag request retries.
+    /// </summary>
+    public int FeatureFlagRequestMaxRetries { get; set; } = 1;
+
     /// <summary>
     /// The initial delay between retries. (Default: 1 second)
     /// </summary>

src/PostHog/Library/HttpClientExtensions.cs

@@ -55,7 +55,7 @@ internal static class HttpClientExtensions
         PostHogOptions options,
         CancellationToken cancellationToken)
     {
-        var maxRetries = options.MaxRetries;
+        var maxRetries = options.FeatureFlagRequestMaxRetries;
         var currentDelay = options.InitialRetryDelay;
         var maxDelay = options.MaxRetryDelay;
         var attempt = 0;

src/PostHog/PublicAPI.Unshipped.txt

@@ -1 +1,3 @@
 #nullable enable
+PostHog.PostHogOptions.FeatureFlagRequestMaxRetries.get -> int
+PostHog.PostHogOptions.FeatureFlagRequestMaxRetries.set -> void

tests/UnitTests/Library/HttpClientExtensionsTests.cs

@@ -590,6 +590,28 @@ public async Task RetriesOnConnectionResetThenSucceeds()
         Assert.Equal(2, handler.RequestCount);
     }
 
+    [Fact]
+    public async Task DoesNotRetryWhenFeatureFlagRequestMaxRetriesIsZero()
+    {
+        var handler = new FakeRetryHttpMessageHandler();
+        handler.AddException(new HttpRequestException("Connection reset", new SocketException((int)SocketError.ConnectionReset)));
+        handler.AddResponse(HttpStatusCode.OK, new { flags = new { } });
+        using var httpClient = CreateHttpClient(handler);
+        var options = CreateOptions();
+        options.FeatureFlagRequestMaxRetries = 0;
+        var timeProvider = new FakeTimeProvider();
+
+        await Assert.ThrowsAsync<HttpRequestException>(() =>
+            httpClient.PostJsonWithNetworkRetryAsync<FlagsApiResult>(
+                FlagsUrl,
+                new { api_key = "test", distinct_id = "user-1" },
+                timeProvider,
+                options,
+                CancellationToken.None));
+
+        Assert.Equal(1, handler.RequestCount);
+    }
+
     [Fact]
     public async Task DoesNotRetryConnectionRefused()
     {