Skip to content

Remove push trigger from CodeQL workflow - #160

Closed
haacked wants to merge 1 commit into
mainfrom
haacked/fix-codeql-release-block
Closed

Remove push trigger from CodeQL workflow#160
haacked wants to merge 1 commit into
mainfrom
haacked/fix-codeql-release-block

Conversation

@haacked

@haacked haacked commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the on: push trigger from the CodeQL workflow to unblock the release workflow
  • The org-level "Address CodeQL findings" ruleset requires CodeQL results before pushing to main. When the release workflow pushes a version bump commit, GitHub blocks it because CodeQL hasn't scanned that new commit yet (failed run)
  • This matches how posthog-go handles it — CodeQL runs on PRs and on a weekly schedule, but not on push to the default branch

Test plan

  • Verify CodeQL still runs on PRs targeting main
  • Re-run the release workflow and confirm the version bump push succeeds

The org-level "Address CodeQL findings" ruleset requires CodeQL results
before pushing to main. When the release workflow pushes a version bump
commit directly to main, GitHub blocks it because CodeQL hasn't scanned
that commit yet.

By removing the push trigger, CodeQL only runs on PRs and on schedule.
This matches how posthog-go handles it and unblocks the release workflow
while still scanning every PR before merge.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions

Copy link
Copy Markdown
Contributor

posthog-dotnet Compliance Report

Date: 2026-02-26 00:01:45 UTC
Duration: 119998ms

✅ All Tests Passed!

29/29 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 152ms
Format Validation.Event Has Uuid 125ms
Format Validation.Event Has Lib Properties 111ms
Format Validation.Distinct Id Is String 110ms
Format Validation.Token Is Present 110ms
Format Validation.Custom Properties Preserved 115ms
Format Validation.Event Has Timestamp 111ms
Retry Behavior.Retries On 503 8122ms
Retry Behavior.Does Not Retry On 400 2021ms
Retry Behavior.Does Not Retry On 401 2014ms
Retry Behavior.Respects Retry After Header 8120ms
Retry Behavior.Implements Backoff 22135ms
Retry Behavior.Retries On 500 6118ms
Retry Behavior.Retries On 502 6119ms
Retry Behavior.Retries On 504 6117ms
Retry Behavior.Max Retries Respected 22023ms
Deduplication.Generates Unique Uuids 116ms
Deduplication.Preserves Uuid On Retry 6116ms
Deduplication.Preserves Uuid And Timestamp On Retry 13129ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6124ms
Deduplication.No Duplicate Events In Batch 116ms
Deduplication.Different Events Have Different Uuids 111ms
Compression.Sends Gzip When Enabled 110ms
Batch Format.Uses Proper Batch Structure 110ms
Batch Format.Flush With No Events Sends Nothing 107ms
Batch Format.Multiple Events Batched Together 115ms
Error Handling.Does Not Retry On 403 2011ms
Error Handling.Does Not Retry On 413 2012ms
Error Handling.Retries On 408 6118ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant