Skip to content

Remove obsolete release scripts - #165

Merged
haacked merged 1 commit into
mainfrom
haacked/update-release-instructions
Mar 5, 2026
Merged

Remove obsolete release scripts#165
haacked merged 1 commit into
mainfrom
haacked/update-release-instructions

Conversation

@haacked

@haacked haacked commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Delete bin/publish and bin/release-local, which are superseded by the label-driven release workflow added in Add label-driven release workflow #157
  • Remove the "Manual Fallback" section from the README that referenced bin/release-local

Test plan

  • dotnet build passes
  • All 1,549 tests pass
  • grep -r 'bin/publish\|bin/release-local' confirms no stale references remain

The label-driven release workflow (.github/workflows/release.yml) fully
automates versioning, tagging, and publishing. Delete the now-unused
bin/publish and bin/release-local scripts and remove the manual fallback
section from the README.
@greptile-apps

greptile-apps Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Last reviewed commit: a2e1d40

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

posthog-dotnet Compliance Report

Date: 2026-03-05 21:51:28 UTC
Duration: 120015ms

✅ All Tests Passed!

29/29 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 154ms
Format Validation.Event Has Uuid 127ms
Format Validation.Event Has Lib Properties 112ms
Format Validation.Distinct Id Is String 111ms
Format Validation.Token Is Present 111ms
Format Validation.Custom Properties Preserved 116ms
Format Validation.Event Has Timestamp 111ms
Retry Behavior.Retries On 503 8124ms
Retry Behavior.Does Not Retry On 400 2020ms
Retry Behavior.Does Not Retry On 401 2013ms
Retry Behavior.Respects Retry After Header 8120ms
Retry Behavior.Implements Backoff 22135ms
Retry Behavior.Retries On 500 6117ms
Retry Behavior.Retries On 502 6119ms
Retry Behavior.Retries On 504 6119ms
Retry Behavior.Max Retries Respected 22024ms
Deduplication.Generates Unique Uuids 117ms
Deduplication.Preserves Uuid On Retry 6116ms
Deduplication.Preserves Uuid And Timestamp On Retry 13127ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6125ms
Deduplication.No Duplicate Events In Batch 117ms
Deduplication.Different Events Have Different Uuids 112ms
Compression.Sends Gzip When Enabled 110ms
Batch Format.Uses Proper Batch Structure 109ms
Batch Format.Flush With No Events Sends Nothing 107ms
Batch Format.Multiple Events Batched Together 116ms
Error Handling.Does Not Retry On 403 2013ms
Error Handling.Does Not Retry On 413 2013ms
Error Handling.Retries On 408 6117ms

@haacked
haacked requested a review from Copilot March 5, 2026 21:54
@haacked
haacked requested a review from a team March 5, 2026 21:55
@haacked
haacked enabled auto-merge March 5, 2026 21:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy manual release scripts and updates documentation to align with the label-driven GitHub Actions release workflow introduced in #157.

Changes:

  • Delete bin/publish and bin/release-local scripts that are no longer used.
  • Remove the README “Manual Fallback” section that referenced bin/release-local.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
bin/release-local Removed obsolete local release preparation script.
bin/publish Removed obsolete NuGet publishing helper script.
README.md Removed documentation for the deleted manual fallback release path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Piccirello Piccirello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@haacked
haacked merged commit e33577d into main Mar 5, 2026
16 checks passed
@haacked
haacked deleted the haacked/update-release-instructions branch March 5, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants