feat(flags): switch local evaluation endpoint to /flags/definitions - #173
Merged
Conversation
Contributor
posthog-dotnet Compliance ReportDate: 2026-04-21 14:26:46 UTC
|
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 43ms |
Failures
request_payload.request_with_person_properties_device_id
404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: tests/TestLibrary/Fakes/FakeHttpMessageHandlerExtensions.cs
Line: 71
Comment:
**URL constant duplicated across test files**
`LocalEvaluationUrl` has no access modifier (private by default), so every test file that needs the raw URI for a custom response — `LocalFeatureFlagsLoaderTests.cs` (defines its own `static readonly Uri LocalEvaluationUrl`) and the inline `new Uri(...)` literals in `FeatureFlagsTests.cs` and `PostHogClientTests.cs` — must repeat the string. This PR updated 7 spots for a single URL change, which is the OnceAndOnlyOnce violation the simplicity rules flag.
Making this field `internal` (and verifying the UnitTests project already has `InternalsVisibleTo` access, or promoting it to `public`) would let every test reference a single source of truth and reduce future churn to one edit.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(flags): switch local evaluation end..." | Re-trigger Greptile |
dustinbyrne
approved these changes
Apr 15, 2026
patricio-posthog
temporarily deployed
to
Release
April 21, 2026 14:31 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Rust feature flags definitions fleet now serves 100% of
/api/feature_flag/local_evaluationtraffic in all environments. This switches the SDK's default polling URL from the legacy Django path to the Rust endpoint's native path (/flags/definitions).The old
/api/feature_flag/local_evaluationpath remains registered as a route alias on the Rust service, so older SDK versions continue to work.How did you test it?
/flags/definitionsendpoint has been serving production traffic since 2026-04-09