chore: use client-id for create-github-app-token - #175
Conversation
posthog-dotnet Compliance ReportDate: 2026-04-16 15:32:20 UTC
|
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 44ms |
Failures
request_payload.request_with_person_properties_device_id
404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 84
Comment:
**Secret value may need to be updated alongside the parameter rename**
A GitHub App has two distinct identifiers: the numeric **App ID** (e.g. `12345`) and the OAuth **Client ID** (e.g. `Iv1.xxxxxxxxxxxxxxxx`). The secret `GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID` is named for the App ID, suggesting it stores the numeric value. The `client-id` input now expects the Client ID string — a different value found in the GitHub App's settings page under "Client ID."
If the secret still holds the numeric App ID, the action may reject it or produce a hard-to-diagnose auth failure on the next release run. Please confirm the secret value is the Client ID (the `Iv1.…` string), and update the secret if it currently stores the numeric App ID.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "chore: use client-id for create-github-a..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| uses: actions/create-github-app-token@v3 | ||
| with: | ||
| app-id: ${{ secrets.GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID }} | ||
| client-id: ${{ secrets.GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID }} |
There was a problem hiding this comment.
A GitHub App has two distinct identifiers: the numeric App ID (e.g. 12345) and the OAuth Client ID (e.g. Iv1.xxxxxxxxxxxxxxxx). The secret GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID is named for the App ID, suggesting it stores the numeric value. The client-id input now expects the Client ID string — a different value found in the GitHub App's settings page under "Client ID."
If the secret still holds the numeric App ID, the action may reject it or produce a hard-to-diagnose auth failure on the next release run. Please confirm the secret value is the Client ID (the Iv1.… string), and update the secret if it currently stores the numeric App ID.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 84
Comment:
**Secret value may need to be updated alongside the parameter rename**
A GitHub App has two distinct identifiers: the numeric **App ID** (e.g. `12345`) and the OAuth **Client ID** (e.g. `Iv1.xxxxxxxxxxxxxxxx`). The secret `GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID` is named for the App ID, suggesting it stores the numeric value. The `client-id` input now expects the Client ID string — a different value found in the GitHub App's settings page under "Client ID."
If the secret still holds the numeric App ID, the action may reject it or produce a hard-to-diagnose auth failure on the next release run. Please confirm the secret value is the Client ID (the `Iv1.…` string), and update the secret if it currently stores the numeric App ID.
How can I resolve this? If you propose a fix, please make it concise.
2 participants
💡 Motivation and Context
GitHub Actions now warns that
app-idis deprecated inactions/create-github-app-token.This updates the release workflow to use
client-idand bumps the action to v3 where needed.💚 How did you test it?
git diff --check📝 Checklist
If releasing new changes
releaselabel to the PRbump-patch,bump-minor, orbump-major