Skip to content

chore: use client-id for create-github-app-token #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 1 commit into from
Apr 16, 2026
Merged

chore: use client-id for create-github-app-token #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ jobs:

- name: Get GitHub App token
id: releaser
uses: actions/create-github-app-token@v2
uses: actions/create-github-app-token@v3
with:
app-id: ${{ secrets.GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID }}
client-id: ${{ secrets.GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID }}

@greptile-apps greptile-apps Bot Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Secret value may need to be updated alongside the parameter rename

A GitHub App has two distinct identifiers: the numeric App ID (e.g. 12345) and the OAuth Client ID (e.g. Iv1.xxxxxxxxxxxxxxxx). The secret GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID is named for the App ID, suggesting it stores the numeric value. The client-id input now expects the Client ID string — a different value found in the GitHub App's settings page under "Client ID."

If the secret still holds the numeric App ID, the action may reject it or produce a hard-to-diagnose auth failure on the next release run. Please confirm the secret value is the Client ID (the Iv1.… string), and update the secret if it currently stores the numeric App ID.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 84

Comment:
**Secret value may need to be updated alongside the parameter rename**

A GitHub App has two distinct identifiers: the numeric **App ID** (e.g. `12345`) and the OAuth **Client ID** (e.g. `Iv1.xxxxxxxxxxxxxxxx`). The secret `GH_APP_POSTHOG_DOTNET_RELEASER_APP_ID` is named for the App ID, suggesting it stores the numeric value. The `client-id` input now expects the Client ID string — a different value found in the GitHub App's settings page under "Client ID."

If the secret still holds the numeric App ID, the action may reject it or produce a hard-to-diagnose auth failure on the next release run. Please confirm the secret value is the Client ID (the `Iv1.…` string), and update the secret if it currently stores the numeric App ID.

How can I resolve this? If you propose a fix, please make it concise.

private-key: ${{ secrets.GH_APP_POSTHOG_DOTNET_RELEASER_PRIVATE_KEY }}

- name: Checkout
Expand Down
Loading