feat(js-sdk): Enable $web_vitals reporting when cookieless mode is enabled#3607
Draft
eli-r-ph wants to merge 1 commit into
Draft
feat(js-sdk): Enable $web_vitals reporting when cookieless mode is enabled#3607eli-r-ph wants to merge 1 commit into
eli-r-ph wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Right now reporting of
$web_vitalsis disabled whencookieless_modeis enabled, because cookieless mode disables the session ID manager, which gates vitals logic.I think this is a safe change because the ingestion (backend) processing because:
$session_idis generated for cookieless-enabled eventsI think this is safe on the product (access path side) because:
$session_idis available on cookieless web vitals eventsAd-hoc HogQL queries could attempt to access a nested session ID (available on cookieless-disabled events only) and this could break in the product. I'm not sure whether this is a blocker on shipping the change
Changes
$web_vitalsevents even when cookieless mode is enabled (session ID manager not present)Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file