-
Notifications
You must be signed in to change notification settings - Fork 31
Expand file tree
/
Copy pathFeatureFlagTest.php
More file actions
568 lines (492 loc) · 21.7 KB
/
FeatureFlagTest.php
File metadata and controls
568 lines (492 loc) · 21.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
<?php
namespace PostHog\Test;
// comment out below to print all logs instead of failing tests
require_once 'test/error_log_mock.php';
use Exception;
use PHPUnit\Framework\TestCase;
use PostHog\Client;
use PostHog\PostHog;
use PostHog\Test\Assets\MockedResponses;
class FeatureFlagTest extends TestCase
{
use ClockMockTrait;
const FAKE_API_KEY = "random_key";
private $http_client;
private $client;
public function setUp($flagsEndpointResponse = MockedResponses::FLAGS_RESPONSE, $personalApiKey = "test"): void
{
date_default_timezone_set("UTC");
$this->http_client = new MockedHttpClient("app.posthog.com", flagsEndpointResponse: $flagsEndpointResponse);
$this->client = new Client(
self::FAKE_API_KEY,
[
"debug" => true,
],
$this->http_client,
$personalApiKey
);
PostHog::init(null, null, $this->client);
// Reset the errorMessages array before each test
global $errorMessages;
$errorMessages = [];
}
public function checkEmptyErrorLogs(): void
{
global $errorMessages;
$this->assertTrue(empty($errorMessages), "Error logs are not empty: " . implode("\n", $errorMessages));
}
public static function decideResponseCases(): array
{
return [
'v3 response' => [MockedResponses::FLAGS_RESPONSE],
'v4 response' => [MockedResponses::FLAGS_V2_RESPONSE]
];
}
/**
* @dataProvider decideResponseCases
*/
public function testIsFeatureEnabled($response)
{
$this->setUp($response);
$this->assertFalse(PostHog::isFeatureEnabled('having_fun', 'user-id'));
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/api/feature_flag/local_evaluation?send_cohorts&token=random_key",
"payload" => null,
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION, 1 => 'Authorization: Bearer test'),
"requestOptions" => array("includeEtag" => true),
),
1 => array(
"path" => "/flags/?v=2",
"payload" => sprintf('{"api_key":"%s","distinct_id":"user-id","person_properties":{"distinct_id":"user-id"}}', self::FAKE_API_KEY),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
)
);
}
public function testIsFeatureEnabledCapturesFeatureFlagCalledEventWithAdditionalMetadata()
{
$this->executeAtFrozenDateTime(new \DateTime('2022-05-01'), function () {
$this->setUp(MockedResponses::FLAGS_V2_RESPONSE, personalApiKey: null);
$this->assertTrue(PostHog::isFeatureEnabled('simple-test', 'user-id'));
PostHog::flush();
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/flags/?v=2",
"payload" => sprintf('{"api_key":"%s","distinct_id":"user-id","person_properties":{"distinct_id":"user-id"}}', self::FAKE_API_KEY),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
1 => array(
"path" => "/batch/",
"payload" => '{"batch":[{"properties":{"$feature_flag":"simple-test","$feature_flag_response":true,"$feature_flag_request_id":"98487c8a-287a-4451-a085-299cd76228dd","$feature_flag_id":6,"$feature_flag_version":1,"$feature_flag_reason":"Matched condition set 1","$lib":"posthog-php","$lib_version":"' . PostHog::VERSION . '","$lib_consumer":"LibCurl","$groups":[]},"distinct_id":"user-id","event":"$feature_flag_called","$groups":[],"library":"posthog-php","library_version":"' . PostHog::VERSION . '","library_consumer":"LibCurl","groups":[],"timestamp":"2022-05-01T00:00:00+00:00","type":"capture"}],"api_key":"random_key"}',
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array('shouldVerify' => true),
),
)
);
});
}
public function testWhitespacePersonalApiKeyFallsBackToFlagsEndpoint()
{
$this->setUp(MockedResponses::FLAGS_V2_RESPONSE, personalApiKey: " \n\t ");
$this->assertTrue(PostHog::isFeatureEnabled('simple-test', 'user-id'));
$this->assertEquals(
[
[
"path" => "/flags/?v=2",
"payload" => sprintf('{"api_key":"%s","distinct_id":"user-id","person_properties":{"distinct_id":"user-id"}}', self::FAKE_API_KEY),
"extraHeaders" => [0 => 'User-Agent: posthog-php/' . PostHog::VERSION],
"requestOptions" => ["timeout" => 3000, "shouldRetry" => false],
],
],
$this->http_client->calls
);
}
/**
* @dataProvider decideResponseCases
*/
public function testIsFeatureEnabledGroups($response)
{
$this->setUp($response);
$this->assertFalse(PostHog::isFeatureEnabled('having_fun', 'user-id', array("company" => "id:5")));
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/api/feature_flag/local_evaluation?send_cohorts&token=random_key",
"payload" => null,
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION, 1 => 'Authorization: Bearer test'),
"requestOptions" => array("includeEtag" => true),
),
1 => array(
"path" => "/flags/?v=2",
"payload" => sprintf(
'{"api_key":"%s","distinct_id":"user-id","groups":{"company":"id:5"},"person_properties":{"distinct_id":"user-id"},"group_properties":{"company":{"$group_key":"id:5"}}}',
self::FAKE_API_KEY
),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
)
);
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlag($response)
{
$this->setUp($response);
$this->assertEquals("variant-value", PostHog::getFeatureFlag('multivariate-test', 'user-id'));
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/api/feature_flag/local_evaluation?send_cohorts&token=random_key",
"payload" => null,
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION, 1 => 'Authorization: Bearer test'),
"requestOptions" => array("includeEtag" => true),
),
1 => array(
"path" => "/flags/?v=2",
"payload" => sprintf('{"api_key":"%s","distinct_id":"user-id","person_properties":{"distinct_id":"user-id"}}', self::FAKE_API_KEY),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
)
);
}
public function testGetFeatureFlagCapturesFeatureFlagCalledEventWithAdditionalMetadata()
{
$this->executeAtFrozenDateTime(new \DateTime('2022-05-01'), function () {
$this->setUp(MockedResponses::FLAGS_V2_RESPONSE, personalApiKey: null);
$this->assertEquals("variant-value", PostHog::getFeatureFlag('multivariate-test', 'user-id'));
PostHog::flush();
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/flags/?v=2",
"payload" => sprintf('{"api_key":"%s","distinct_id":"user-id","person_properties":{"distinct_id":"user-id"}}', self::FAKE_API_KEY),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
1 => array(
"path" => "/batch/",
"payload" => '{"batch":[{"properties":{"$feature_flag":"multivariate-test","$feature_flag_response":"variant-value","$feature_flag_request_id":"98487c8a-287a-4451-a085-299cd76228dd","$feature_flag_id":7,"$feature_flag_version":3,"$feature_flag_reason":"Matched condition set 2","$lib":"posthog-php","$lib_version":"' . PostHog::VERSION . '","$lib_consumer":"LibCurl","$groups":[]},"distinct_id":"user-id","event":"$feature_flag_called","$groups":[],"library":"posthog-php","library_version":"' . PostHog::VERSION . '","library_consumer":"LibCurl","groups":[],"timestamp":"2022-05-01T00:00:00+00:00","type":"capture"}],"api_key":"random_key"}',
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array('shouldVerify' => true),
),
)
);
});
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagDefault($response)
{
$this->setUp($response);
$this->assertEquals(PostHog::getFeatureFlag('blah', 'user-id'), null);
$this->checkEmptyErrorLogs();
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagGroups($response)
{
$this->setUp($response);
$this->assertEquals(
"variant-value",
PostHog::getFeatureFlag('multivariate-test', 'user-id', array("company" => "id:5"))
);
$this->assertEquals(
$this->http_client->calls,
array(
0 => array(
"path" => "/api/feature_flag/local_evaluation?send_cohorts&token=random_key",
"payload" => null,
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION, 1 => 'Authorization: Bearer test'),
"requestOptions" => array("includeEtag" => true),
),
1 => array(
"path" => "/flags/?v=2",
"payload" => sprintf(
'{"api_key":"%s","distinct_id":"user-id","groups":{"company":"id:5"},"person_properties":{"distinct_id":"user-id"},"group_properties":{"company":{"$group_key":"id:5"}}}',
self::FAKE_API_KEY
),
"extraHeaders" => array(0 => 'User-Agent: posthog-php/' . PostHog::VERSION),
"requestOptions" => array("timeout" => 3000, "shouldRetry" => false),
),
)
);
}
/**
* @dataProvider decideResponseCases
*/
public function testfetchFeatureVariants($response)
{
$this->setUp($response);
$this->assertIsArray(PostHog::fetchFeatureVariants('user-id'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesJson($response): void
{
$this->setUp($response);
$this->assertSame(['key' => 'value'], PostHog::getFeatureFlagPayload('json-payload', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesIntegers($response): void
{
$this->setUp($response);
$this->assertSame(2500, PostHog::getFeatureFlagPayload('integer-payload', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesString($response): void
{
$this->setUp($response);
$this->assertSame('A String', PostHog::getFeatureFlagPayload('string-payload', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesArray($response): void
{
$this->setUp($response);
$this->assertSame([1, 2, 3], PostHog::getFeatureFlagPayload('array-payload', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesFlagDisabled($response): void
{
$this->setUp($response);
$this->assertNull(PostHog::getFeatureFlagPayload('disabled-flag', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagPayloadHandlesFlagNotInResults($response): void
{
$this->setUp($response);
$this->assertNull(PostHog::getFeatureFlagPayload('non-existent-flag', 'some-distinct'));
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResult($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('json-payload', 'user-id');
$this->assertNotNull($result);
$this->assertEquals('json-payload', $result->getKey());
$this->assertTrue($result->isEnabled());
$this->assertNull($result->getVariant());
$this->assertEquals(['key' => 'value'], $result->getPayload());
$this->assertTrue($result->getValue());
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultWithMultivariateFlag($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('multivariate-test', 'user-id');
$this->assertNotNull($result);
$this->assertEquals('multivariate-test', $result->getKey());
$this->assertTrue($result->isEnabled());
$this->assertEquals('variant-value', $result->getVariant());
$this->assertEquals('variant-value', $result->getValue());
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultReturnsNullForMissingFlag($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('non-existent-flag', 'user-id');
$this->assertNull($result);
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultForDisabledFlag($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('disabled-flag', 'user-id');
$this->assertNotNull($result);
$this->assertEquals('disabled-flag', $result->getKey());
$this->assertFalse($result->isEnabled());
$this->assertNull($result->getVariant());
$this->assertFalse($result->getValue());
}
public function testGetFeatureFlagResultSendsEvent(): void
{
$this->executeAtFrozenDateTime(new \DateTime('2022-05-01'), function () {
$this->setUp(MockedResponses::FLAGS_V2_RESPONSE, personalApiKey: null);
$result = PostHog::getFeatureFlagResult('json-payload', 'user-id');
PostHog::flush();
$this->assertNotNull($result);
$this->assertEquals(['key' => 'value'], $result->getPayload());
// Verify that the $feature_flag_called event was sent
$batchCall = null;
foreach ($this->http_client->calls as $call) {
if ($call['path'] === '/batch/') {
$batchCall = $call;
break;
}
}
$this->assertNotNull($batchCall, 'Expected a batch call to be made');
$payload = json_decode($batchCall['payload'], true);
$this->assertNotEmpty($payload['batch']);
$event = $payload['batch'][0];
$this->assertEquals('$feature_flag_called', $event['event']);
$this->assertEquals('json-payload', $event['properties']['$feature_flag']);
$this->assertTrue($event['properties']['$feature_flag_response']);
});
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultWithMultivariateFlagAndPayload($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('multivariate-simple-test', 'user-id');
$this->assertNotNull($result);
$this->assertEquals('multivariate-simple-test', $result->getKey());
$this->assertTrue($result->isEnabled());
$this->assertEquals('variant-simple-value', $result->getVariant());
$this->assertEquals('variant-simple-value', $result->getValue());
$this->assertEquals('some string payload', $result->getPayload());
}
public function testGetFeatureFlagPayloadDoesNotSendEvent(): void
{
$this->setUp(MockedResponses::FLAGS_V2_RESPONSE, personalApiKey: null);
$payload = PostHog::getFeatureFlagPayload('json-payload', 'user-id');
PostHog::flush();
$this->assertEquals(['key' => 'value'], $payload);
// Verify that NO batch call was made (no event sent)
$batchCall = null;
foreach ($this->http_client->calls as $call) {
if ($call['path'] === '/batch/') {
$batchCall = $call;
break;
}
}
$this->assertNull($batchCall, 'Expected no batch call to be made for getFeatureFlagPayload');
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultForDisabledFlagWithPayload($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult('disabled-flag-with-payload', 'user-id');
$this->assertNotNull($result);
$this->assertEquals('disabled-flag-with-payload', $result->getKey());
$this->assertFalse($result->isEnabled());
$this->assertNull($result->getVariant());
$this->assertFalse($result->getValue());
$this->assertEquals(['disabled' => true], $result->getPayload());
}
public function testGetFeatureFlagResultWithLocalEvaluationOnly(): void
{
// For local evaluation, we need to set flagEndpointResponse (not flagsEndpointResponse)
$this->http_client = new MockedHttpClient(
host: "app.posthog.com",
flagEndpointResponse: MockedResponses::LOCAL_EVALUATION_SIMPLE_REQUEST
);
$this->client = new Client(
self::FAKE_API_KEY,
["debug" => true],
$this->http_client,
"test"
);
PostHog::init(null, null, $this->client);
// Flag can be evaluated locally - should return result
$result = PostHog::getFeatureFlagResult(
'simple-flag',
'user-id',
[],
[],
[],
true // onlyEvaluateLocally
);
$this->assertNotNull($result);
$this->assertEquals('simple-flag', $result->getKey());
$this->assertTrue($result->isEnabled());
// Verify no /flags/ network call was made
foreach ($this->http_client->calls as $call) {
$this->assertStringNotContainsString('/flags/', $call['path'], 'Expected no /flags/ call for local evaluation');
}
}
public function testGetFeatureFlagResultReturnsNullForLocalEvaluationWhenFlagCannotBeEvaluatedLocally(): void
{
// Use a flag config that requires cohorts which can't be evaluated locally
$this->http_client = new MockedHttpClient(
host: "app.posthog.com",
flagEndpointResponse: MockedResponses::LOCAL_EVALUATION_WITH_COHORTS_REQUEST
);
$this->client = new Client(
self::FAKE_API_KEY,
["debug" => true],
$this->http_client,
"test"
);
PostHog::init(null, null, $this->client);
// beta-feature requires cohort evaluation which needs server
// When onlyEvaluateLocally is true, should return null
$result = PostHog::getFeatureFlagResult(
'beta-feature',
'user-id',
[],
[],
[],
true // onlyEvaluateLocally
);
$this->assertNull($result);
// Verify no /flags/ network call was made
foreach ($this->http_client->calls as $call) {
$this->assertStringNotContainsString('/flags/', $call['path'], 'Expected no /flags/ call for local evaluation only');
}
}
/**
* @dataProvider decideResponseCases
*/
public function testGetFeatureFlagResultWithGroups($response): void
{
$this->setUp($response);
$result = PostHog::getFeatureFlagResult(
'group-flag',
'user-id',
['company' => 'id:5']
);
$this->assertNotNull($result);
$this->assertEquals('group-flag', $result->getKey());
$this->assertTrue($result->isEnabled());
$this->assertEquals('decide-fallback-value', $result->getVariant());
// Verify that groups were passed in the /flags/ request
$flagsCall = null;
foreach ($this->http_client->calls as $call) {
if (str_contains($call['path'], '/flags/')) {
$flagsCall = $call;
break;
}
}
$this->assertNotNull($flagsCall, 'Expected a /flags/ call to be made');
$payload = json_decode($flagsCall['payload'], true);
$this->assertArrayHasKey('groups', $payload);
$this->assertEquals(['company' => 'id:5'], $payload['groups']);
}
}