refactor: simplify php error tracking internals

Author: cat-ph

README.md

@@ -37,25 +37,21 @@ Opt-in automatic capture from the core SDK:
 
 ```php
 PostHog::init('phc_xxx', [
-    'enable_error_tracking' => true,
-    'capture_uncaught_exceptions' => true,
-    'capture_errors' => true,
-    'capture_fatal_errors' => true,
-    'error_reporting_mask' => E_ALL,
-    'excluded_exceptions' => [
-        \InvalidArgumentException::class,
+    'error_tracking' => [
+        'enabled' => true,
+        'capture_errors' => true,
+        'excluded_exceptions' => [
+            \InvalidArgumentException::class,
+        ],
+        'context_provider' => static function (array $payload): array {
+            return [
+                'distinctId' => $_SESSION['user_id'] ?? null,
+                'properties' => [
+                    '$current_url' => $_SERVER['REQUEST_URI'] ?? null,
+                ],
+            ];
+        },
     ],
-    'error_tracking_include_source_context' => true,
-    'error_tracking_context_lines' => 5,
-    'error_tracking_max_frames' => 20,
-    'error_tracking_context_provider' => static function (array $payload): array {
-        return [
-            'distinctId' => $_SESSION['user_id'] ?? null,
-            'properties' => [
-                '$current_url' => $_SERVER['REQUEST_URI'] ?? null,
-            ],
-        ];
-    },
 ]);
 ```
 

example.php

@@ -525,19 +525,17 @@ function errorTrackingExamples()
             'host' => $_ENV['POSTHOG_HOST'] ?? 'https://app.posthog.com',
             'debug' => true,
             'ssl' => !str_starts_with($_ENV['POSTHOG_HOST'] ?? 'https://app.posthog.com', 'http://'),
-            'enable_error_tracking' => true,
-            'capture_uncaught_exceptions' => true,
-            'capture_errors' => true,
-            'capture_fatal_errors' => true,
-            'error_reporting_mask' => E_ALL,
-            'error_tracking_context_provider' => static function (array $payload): array {
-                return [
-                    'distinctId' => 'sdk-demo-user',
-                    'properties' => [
-                        '$error_source' => $payload['source'],
-                    ],
-                ];
-            },
+            'error_tracking' => [
+                'enabled' => true,
+                'context_provider' => static function (array $payload): array {
+                    return [
+                        'distinctId' => 'sdk-demo-user',
+                        'properties' => [
+                            '$error_source' => $payload['source'],
+                        ],
+                    ];
+                },
+            ],
         ],
         null,
         $_ENV['POSTHOG_PERSONAL_API_KEY']

lib/Client.php

@@ -126,7 +126,7 @@ public function __construct(
         $this->distinctIdsFeatureFlagsReported = new SizeLimitedHash(SIZE_LIMIT);
         $this->flagsEtag = null;
 
-        ErrorTrackingRegistrar::configure($this, $options);
+        ExceptionCapture::configure($this, $options['error_tracking'] ?? []);
 
         // Populate featureflags and grouptypemapping if possible
         if (
@@ -205,16 +205,19 @@ public function captureException(
             $distinctId = Uuid::v4();
         }
 
-        $exceptionList = $this->buildExceptionList($exception);
-        if ($exceptionList === null) {
+        $errorTrackingConfig = $this->options['error_tracking'] ?? [];
+        $maxFrames = max(0, (int) ($errorTrackingConfig['max_frames'] ?? 20));
+
+        $exceptionList = ExceptionPayloadBuilder::buildExceptionList($exception, $maxFrames);
+        if (empty($exceptionList)) {
             return false;
         }
 
         $properties = array_merge(
             $additionalProperties,
             [
                 '$exception_list' => $exceptionList,
-                '$exception_handled' => ExceptionCapture::getPrimaryHandled($exceptionList),
+                '$exception_handled' => ExceptionPayloadBuilder::getPrimaryHandled($exceptionList),
             ]
         );
 
@@ -921,22 +924,6 @@ public function flush()
         return true;
     }
 
-    /**
-     * @param \Throwable|string $exception
-     * @return array|null
-     */
-    private function buildExceptionList(\Throwable|string $exception): ?array
-    {
-        ExceptionCapture::configure($this->options);
-
-        $exceptionList = ExceptionCapture::buildParsedException($exception);
-        if ($exceptionList === null) {
-            return null;
-        }
-
-        return ExceptionCapture::normalizeExceptionList($exceptionList);
-    }
-
     /**
      * Formats a timestamp by making sure it is set
      * and converting it to iso8601.