Skip to content

chore(handbook): update SDLC review policy for AI-assisted workflows#16532

Open
webjunkie wants to merge 2 commits intomasterfrom
chore/update-sdlc-review-policy
Open

chore(handbook): update SDLC review policy for AI-assisted workflows#16532
webjunkie wants to merge 2 commits intomasterfrom
chore/update-sdlc-review-policy

Conversation

@webjunkie
Copy link
Copy Markdown
Contributor

@webjunkie webjunkie commented Apr 22, 2026

Clarifies PR authorship, review, and approval rules in the shipping & releasing handbook page to reflect the current state of AI-assisted development at PostHog.

Creating PRs now covers attribution: human-authored vs. agent-authored PRs and how each should be labelled.

Reviewing code distinguishes between AI review agents (Codex, Copilot, Greptile, etc.) that leave feedback and Stamphog as an approval agent. Agent-authored PRs always need a human review.

Merging drops the "fellow team member" requirement, replaced with "always request a review" (which can now be AI-assisted for eligible PRs).

Clarify PR authorship attribution, review, and approval rules ahead of
SOC 2 audit and the upcoming Stamphog blog post. Removes language that
implies only humans can review PRs.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Deploy preview

Status Details Updated (UTC)
🟢 Ready View preview Apr 22, 2026 07:52PM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Vale prose linter → found 8 errors, 35 warnings, 0 suggestions in your markdown

Full report → Copy the linter results into an LLM to batch-fix issues.

Linter being weird? Update the rules!

contents/handbook/engineering/development-process.md — 8 errors, 35 warnings, 0 suggestions
Line Severity Message Rule
15:4 warning Use the Oxford comma before 'and' or 'or' in a list of three or more items. PostHogBase.OxfordComma
20:7 warning 'Roofshots' is a possible misspelling. PostHogBase.Spelling
22:131 warning 'timebound' is a possible misspelling. PostHogBase.Spelling
28:76 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
29:149 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
31:7 warning 'Homogenous' is a possible misspelling. PostHogBase.Spelling
44:30 warning 'hacky' is a possible misspelling. PostHogBase.Spelling
51:111 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
84:7 warning 'Dogfooding' is a possible misspelling. PostHogBase.Spelling
103:162 warning Use American English. Use 'labeling' instead of 'labelling'. PostHogBase.AmericanEnglish
104:50 warning Capitalize 'Feature Flags' for PostHog's product. Use 'feature flags' for the general industry concept. PostHogBase.ProductNames
104:151 warning Capitalize 'Feature Flags' for PostHog's product. Use 'feature flags' for the general industry concept. PostHogBase.ProductNames
122:99 warning 'Dependabot' is a possible misspelling. PostHogBase.Spelling
122:158 warning Use American English. Use 'labeled' instead of 'labelled'. PostHogBase.AmericanEnglish
134:5 warning 'Storybook Visual Regression Tests' heading should be in sentence case, and product names should be capitalized. PostHogBase.SentenceCase
140:6 warning 'Running Tests Locally' heading should be in sentence case, and product names should be capitalized. PostHogBase.SentenceCase
175:41 warning 'conflics' is a possible misspelling. PostHogBase.Spelling
175:124 warning Use the Oxford comma before 'and' or 'or' in a list of three or more items. PostHogBase.OxfordComma
177:1 warning Use 'GitHub' instead of 'Github'. Vale.Terms
199:83 warning Use 'GitHub' instead of 'Github'. Vale.Terms
252:66 warning 'Stamphog' is a possible misspelling. PostHogBase.Spelling
252:99 warning 'Stamphog' is a possible misspelling. PostHogBase.Spelling
252:242 warning 'Stamphog' is a possible misspelling. PostHogBase.Spelling
255:59 warning 'Greptile' is a possible misspelling. PostHogBase.Spelling
274:5 warning Use the Oxford comma before 'and' or 'or' in a list of three or more items. PostHogBase.OxfordComma
276:216 warning Use 'PostHog' instead of 'posthog'. Vale.Terms
321:1 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
323:1 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
325:1 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
327:1 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
353:21 warning 'hign' is a possible misspelling. PostHogBase.Spelling
383:38 warning 'eg' is a possible misspelling. PostHogBase.Spelling
384:113 warning 'eg' is a possible misspelling. PostHogBase.Spelling
391:49 warning 'eg' is a possible misspelling. PostHogBase.Spelling
393:37 warning 'eg' is a possible misspelling. PostHogBase.Spelling
393:82 error Hi, Andy here... use an en dash ( – ) with spaces. On Mac, holding down the Option and hyphen key will give you an en dash. PostHogBase.EnDash
395:68 warning Capitalize 'Feature Flags' for PostHog's product. Use 'Feature flags' for the general industry concept. PostHogBase.ProductNames
395:89 warning Capitalize 'Experiments' for PostHog's product. Use 'experiments' for the general industry concept. PostHogBase.ProductNames
395:189 warning 'sidwways' is a possible misspelling. PostHogBase.Spelling
401:84 warning Capitalize 'Experiments' for PostHog's product. Use 'experiments' for the general industry concept. PostHogBase.ProductNames
401:128 warning Capitalize 'Experiments' for PostHog's product. Use 'experiments' for the general industry concept. PostHogBase.ProductNames
401:168 warning Capitalize 'Experiments' for PostHog's product. Use 'experiments' for the general industry concept. PostHogBase.ProductNames
423:33 warning Use 'Kubernetes' instead of 'kubernetes'. Vale.Terms

@webjunkie webjunkie marked this pull request as ready for review April 22, 2026 19:42
@webjunkie webjunkie requested review from a team, ivanagas and timgl April 22, 2026 19:42
@rnegron
Copy link
Copy Markdown
Member

rnegron commented Apr 22, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants