Update two docs for clarity#17297
Open
phildelgobbo wants to merge 2 commits into
Open
Conversation
Clarified the description of the first touchpoint attribution mode based on this ticket: https://posthog.slack.com/archives/C04G7E5K5U3/p1778527993829529?thread_ts=1778505884.017919&cid=C04G7E5K5U3 Originally indicated this setting looks for the first instance of a property within the confines of the funnel. In truth the first occurrence of any funnel event, even outside the date range of the funnel, is included.
Clarify that evaluation contexts do not impact local evaluation behavior.
Contributor
Deploy preview
|
Contributor
|
Vale prose linter → found 0 errors, 38 warnings, 7 suggestions in your markdown Full report → Copy the linter results into an LLM to batch-fix issues. Linter being weird? Update the rules!
|
| Line | Severity | Message | Rule |
|---|---|---|---|
| 296:12 | warning | Capitalize 'Feature Flags' for PostHog's product. Use 'feature flags' for the general industry concept. | PostHogBase.ProductNames |
| 331:5 | warning | Capitalize 'Feature Flags' for PostHog's product. Use 'feature flags' for the general industry concept. | PostHogBase.ProductNames |
contents/docs/product-analytics/funnels.mdx — 0 errors, 36 warnings, 7 suggestions
| Line | Severity | Message | Rule |
|---|---|---|---|
| 21:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 23:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 25:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 27:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 29:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 31:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 33:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 35:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 37:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 39:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 41:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 43:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 45:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 47:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 49:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 51:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 53:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 55:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 57:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 59:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 61:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 63:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 65:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 67:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 69:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 71:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 73:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 75:54 | warning | Use 'PostHog' instead of 'posthog'. | Vale.Terms |
| 86:23 | warning | 'unsuccessul' is a possible misspelling. | PostHogBase.Spelling |
| 139:69 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 141:134 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 184:90 | suggestion | Address the reader directly. Use 'you can' instead of 'users can'. | PostHogDocs.DirectAddress |
| 210:16 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 219:11 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 221:14 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 223:15 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 232:10 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 234:13 | warning | 'touchpoint' is a possible misspelling. | PostHogBase.Spelling |
| 263:96 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 302:205 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 304:76 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 304:276 | suggestion | Address the reader directly. Use 'you' instead of 'the user'. | PostHogDocs.DirectAddress |
| 395:197 | warning | 'experiece' is a possible misspelling. | PostHogBase.Spelling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two docs are 1. Funnels and 2. Creating Feature Flags
Clarified the description of the first touchpoint attribution mode based on this ticket: https://posthog.slack.com/archives/C04G7E5K5U3/p1778527993829529?thread_ts=1778505884.017919&cid=C04G7E5K5U3
Originally indicated this setting looks for the first instance of a property within the confines of the funnel. In truth the first occurrence of any funnel event, even outside the date range of the funnel, is included.
Added a note on interaction between evaluation contexts and local evaluation based on this ticket: https://posthog.slack.com/archives/C05KCMDMU8G/p1780492381372119
Originally was missing any notes, causing PostHogAI to hallucinate an answer. More clarity should help here.