-
Notifications
You must be signed in to change notification settings - Fork 864
Fixes blog not appearing under Company nav dropdown #18714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+6
−6
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
329a519
feat(nav): reorder Company dropdown to About, Blog, Handbook, Customers
andyvan-ph d8a5618
Merge branch 'master' into posthog-code/company-menu-reorder
andyvan-ph 57fc0fa
Apply suggestions from code review
andyvan-ph f5aa290
Merge branch 'master' into posthog-code/company-menu-reorder
andyvan-ph 4516725
Update menuData.tsx
andyvan-ph abe2b8a
Merge branch 'master' into posthog-code/company-menu-reorder
andyvan-ph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to remove this? I think it's worth keeping and there isn't an argument for it in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explained it in another PR but Andy edited this one - that information is already surfaced under small teams, it's confusing what WIP vs. Roadmap means, and the list of items here is getting long
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave this for now.
My incoming Roadmap PR is going to shake up how the Roadmap works, and I personally really like the WIP page because it's the only place you can see what the company is actually focused on this quarter. The only alternative is having to go one-by-one through every individual team, or using the Slack bot to query this.
If there's a strong feeling against it then I'd be happy to remove it in a subsequent PR that combines it into the imminent /roadmap page - I agree a single Roadmap page with this info would be ideal - but right now we created the /wip to solve a problem, and getting rid of it just re-introduces that problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlescook-ph's suggestion. I don't care either way.