fix(tracing): remove expandable row feature from virtualized span list#67279
Merged
talyn-app[bot] merged 2 commits intoJul 1, 2026
Conversation
Generated-By: PostHog Code
Contributor
|
Reviews (1): Last reviewed commit: "fix(tracing): remove expandable row feat..." | Re-trigger Greptile |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean feature removal — consistently strips the expandable-row functionality (toggle action, reducer, dynamic row height, expand button, expanded content rendering) across all four files with no dangling references or regressions. Author owns the area, risk is low.
Contributor
|
Size Change: +436 kB (+0.63%) Total Size: 69.9 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
❌ Eager graphHow much code each root forces the browser to download and decode through static imports — the regression class total bundle size can't see.
✅ Largest files eagerly reachable from
|
| Size | File |
|---|---|
| 927.9 KiB | src/styles/global.scss |
| 609.0 KiB | public/hedgehog/burning-money-hog.png |
| 541.9 KiB | public/hedgehog/waving-hog.png |
| 357.8 KiB | ../node_modules/.pnpm/@posthog+icons@0.37.4_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 343.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 301.5 KiB | src/lib/api.ts |
| 279.2 KiB | ../node_modules/.pnpm/posthog-js@1.396.3/node_modules/posthog-js/dist/rrweb.js |
| 268.2 KiB | ../common/tailwind/tailwind.css |
| 264.9 KiB | src/queries/schema/schema-general.ts |
| 228.3 KiB | src/types.ts |
Largest files eagerly reachable from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 1.92 MiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/code-bubble.mjs |
| 1.25 MiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/einstein-group.mjs |
| 1.07 MiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/evel.mjs |
| 927.9 KiB | src/styles/global.scss |
| 919.6 KiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/driving-hogzilla.mjs |
| 787.8 KiB | src/queries/validators.js |
| 739.3 KiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/coding-group.mjs |
| 692.5 KiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/wizard-hog.mjs |
| 677.6 KiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/lemonade.mjs |
| 640.1 KiB | ../node_modules/.pnpm/@posthog+brand@0.3.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/scott-pilgrim.mjs |
Posted automatically by check-eager-graph · sizes are input-source bytes from the esbuild metafile · part of #32479
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
…-feature-from-products-tracing Generated-By: PostHog Code Task-Id: 0e63faee-fa66-466b-8638-6ed0bd466aa0
talyn-app
Bot
deleted the
posthog-code/remove-chevron-expandable-row-feature-from-products-tracing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The expandable row feature in the virtualized span list added complexity without providing sufficient value. Users can still view full span details by clicking on a row to open the drawer, making the inline expansion redundant.
Changes
expandedSpanIdsstate andtoggleExpandSpanaction fromtracingSceneLogicSpanRowcomponentCOL_WIDTH.expand) from the span list header and rowsExpandedSpanContentrendering fromSpanListRowuseDynamicRowHeight) since rows are now fixed heightSpanRowprops to only requirespanandonClickExpandedSpanContentJSDoc to remove reference to the expand-row featureIconChevronRight,LemonButton,useEffect,useDynamicRowHeight)How did you test this code?
This is a straightforward feature removal with no new functionality. The changes:
Created with PostHog Code