chore(clickhouse): sanity-check ai_events convergence gate (expected fail)#67446
chore(clickhouse): sanity-check ai_events convergence gate (expected fail)#67446orian wants to merge 1 commit into
Conversation
…to fail CI) Deliberate negative test: ALTER sharded_ai_events to add a column on NodeRole.AI_EVENTS, with NO matching HCL golden change. The multinode smoke's convergence gate should introspect the ai_events node, see the extra column against golden/local-ai_events.hcl, and fail check-live. Not for merge.
|
Reviews (1): Last reviewed commit: "chore(clickhouse): sanity-check ai_event..." | Re-trigger Greptile |
| @@ -1 +1 @@ | |||
| 0284_message_assets | |||
| 0285_ai_events_gate_drift_check No newline at end of file | |||
There was a problem hiding this comment.
The file is missing a trailing newline after the update. The previous value (
0284_message_assets) had one, and most text files in the repo follow the same convention — some tooling also expects it.
| 0285_ai_events_gate_drift_check | |
| 0285_ai_events_gate_drift_check |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
ClickHouse migration SQL per cloud environment
|
|
Sanity check complete ✅ — the multinode smoke failed exactly as intended: migration 0285 altered sharded_ai_events with no HCL change, and the convergence gate caught it ( |
Problem
Deliberate negative test of the merged convergence gate (#67134, #67281): prove the multinode smoke fails when a migration drifts a managed cluster from its HCL golden.
Changes
0285adds a column tosharded_ai_eventsonNodeRole.AI_EVENTS, with no matchingposthog/clickhouse/hcl/change.Expected outcome:
ci-clickhouse-multinode-migrationsfails at thecheck_live_hclstep withDRIFT: local/ai_events … ALTER table posthog.sharded_ai_events. Not for merge — will be closed.How did you test this code?
I'm an agent. Reproduced locally against the running multinode stack via the pinned hclexp container: with the ALTER applied,
check-live(enforcing) reports the singlesharded_ai_eventsdrift and exits non-zero; ops stays clean. This PR is to confirm the same failure in real CI.🤖 Agent context
Autonomy: Human-driven (agent-assisted). Sanity check requested to validate the enforcing gate end to end. Migration-only; to be closed once CI shows red.