Skip to content

chore(clickhouse): sanity-check ai_events convergence gate (expected fail) #67446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orian wants to merge 1 commit into from
Closed

chore(clickhouse): sanity-check ai_events convergence gate (expected fail) #67446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions posthog/clickhouse/migrations/0285_ai_events_gate_drift_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
from posthog.clickhouse.client.connection import NodeRole
from posthog.clickhouse.client.migration_tools import run_sql_with_exceptions

operations = [
run_sql_with_exceptions(
"ALTER TABLE sharded_ai_events ADD COLUMN IF NOT EXISTS gate_drift_sanity_check UInt8 DEFAULT 0",
node_roles=[NodeRole.AI_EVENTS],
sharded=False,
is_alter_on_replicated_table=True,
),
]
2 changes: 1 addition & 1 deletion posthog/clickhouse/migrations/max_migration.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0284_message_assets
0285_ai_events_gate_drift_check

@greptile-apps greptile-apps Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline after the update. The previous value (0284_message_assets) had one, and most text files in the repo follow the same convention — some tooling also expects it.

Suggested change
0285_ai_events_gate_drift_check
0285_ai_events_gate_drift_check

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Loading