Skip to content

revert: restore archive-completeness check in the MCP manifest test #71707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gewenyu99 merged 1 commit into from
Jul 16, 2026
+8 −8
Merged

revert: restore archive-completeness check in the MCP manifest test #71707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions services/mcp/tests/integration/manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { describe, expect, it } from 'vitest'
import { fetchContextMillResources, loadManifestFromArchive } from '@/resources/internals'

describe('Context-Mill Manifest Integration', () => {
it('should fetch, unzip, and validate available resources from GitHub releases', async () => {
it('should fetch, unzip, and validate the manifest from GitHub releases', async () => {
const archive = await fetchContextMillResources()

// Verify archive is not empty
Expand All @@ -16,19 +16,19 @@ describe('Context-Mill Manifest Integration', () => {
expect(validatedManifest.version).toBe('1.0')
expect(Array.isArray(validatedManifest.resources)).toBe(true)

// The manifest may include resources that are not part of the aggregate archive.
const availableResources = validatedManifest.resources.filter((entry) => !entry.file || archive[entry.file])
// Verify we have actual resources
expect(validatedManifest.resources.length).toBeGreaterThan(0)

// Verify the archive contains actual resources
expect(availableResources.length).toBeGreaterThan(0)

// Verify each available resource has required fields
for (const entry of availableResources) {
// Verify each resource has required fields and its file exists in archive
for (const entry of validatedManifest.resources) {
expect(entry.id).toBeTruthy()
expect(entry.name).toBeTruthy()
expect(entry.resource).toBeTruthy()
expect(entry.resource.mimeType).toBeTruthy()
expect(entry.resource.text).toBeTruthy()
if (entry.file) {
expect(archive[entry.file]).toBeTruthy()
}
}
}, 30000)
})
Loading