Skip to content

Commit ac5f48f

Browse files
authored
Merge pull request #1687 from PostHog/fix-logdir-ci
Fix the broken yargs mapping
2 parents 6e0b9f5 + c13a926 commit ac5f48f

5 files changed

Lines changed: 4 additions & 10 deletions

File tree

.env.example

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,4 @@ WIZARD_PATH=~/development/wizard
99
POSTHOG_PERSONAL_API_KEY=phx_...
1010
# POSTHOG_REGION is optional, defaults to 'us'. Can also be passed via --region flag or workflow input.
1111
# POSTHOG_REGION=us
12-
# Optional wizard log output directory. Wizard writes posthog-wizard.log inside this directory.
13-
# POSTHOG_WIZARD_LOG_DIR=/tmp
1412
POSTHOG_WIZARD_PROJECT_ID=123

.github/workflows/wizard-ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,6 @@ jobs:
669669
POSTHOG_REF: ${{ needs.discover.outputs.input_posthog_ref }}
670670
CI_SOURCE: ${{ needs.discover.outputs.input_source }}
671671
POSTHOG_WIZARD_YARA_REPORT: 'true'
672-
POSTHOG_WIZARD_LOG_DIR: /tmp
673672
POSTHOG_PROJECT_TOKEN: ${{ secrets.POSTHOG_PROJECT_TOKEN }}
674673

675674
- name: Process results
@@ -765,7 +764,7 @@ jobs:
765764
aws s3 cp context-mill-mcp-resources.zip "${S3_PREFIX}/context-mill-mcp-resources.zip" || true
766765
aws s3 cp skills-mcp-resources.zip "${S3_PREFIX}/skills-mcp-resources.zip" || true
767766
768-
WIZARD_LOG="${POSTHOG_WIZARD_LOG_DIR}/posthog-wizard.log"
767+
WIZARD_LOG="/tmp/posthog-wizard.log"
769768
if [ -f "$WIZARD_LOG" ]; then
770769
aws s3 cp "$WIZARD_LOG" "${S3_PREFIX}/posthog-wizard.log" || true
771770
fi
@@ -778,7 +777,6 @@ jobs:
778777
MATRIX_APP: ${{ matrix.app }}
779778
TRIGGER_ID: ${{ needs.discover.outputs.trigger_id }}
780779
AWS_BUCKET: ${{ secrets.AWS_WIZARD_ARTIFACTS_BUCKET }}
781-
POSTHOG_WIZARD_LOG_DIR: /tmp
782780

783781
- name: Label and close PR
784782
if: steps.process-results.outputs.pr_number

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ cp .env.example .env
103103
| `WIZARD_PATH` | Yes | Path to your local wizard repo (e.g., `~/development/wizard`) |
104104
| `POSTHOG_PERSONAL_API_KEY` | For CI | PostHog personal API key for wizard CI mode and PR evaluator |
105105
| `POSTHOG_REGION` | No | PostHog region (`us` or `eu`). Defaults to `us`. Can also be set via `--region` flag or workflow input. |
106-
| `POSTHOG_WIZARD_LOG_DIR` | No | Directory for wizard verbose logs. Wizard writes `posthog-wizard.log` inside this directory (defaults to `/tmp`). |
107106

108107
Make sure you've set up and installed dependencies for all required repos.
109108

@@ -133,7 +132,7 @@ Use keyboard shortcuts in phrocs: `r` to run/restart, `s` to stop, `q` to quit.
133132
| Process | Description |
134133
|---------|-------------|
135134
| `wizard-run` | Interactive picker: choose a wizard command (`posthog-wizard`, `posthog-wizard revenue`, …) then an app |
136-
| `wizard-tail-run` | Tail the wizard's verbose output (`$POSTHOG_WIZARD_LOG_DIR/posthog-wizard.log`, defaults to `/tmp/posthog-wizard.log`) |
135+
| `wizard-tail-run` | Tail the wizard's verbose output (`/tmp/posthog-wizard.log`) |
137136
| `wizard-ci-run` | Full CI flow: run wizard, create PR, evaluate |
138137
| `wizard-ci-local-run` | CI flow with local evaluation (no PR) |
139138
| `wizard-ci-create-pr` | Push branch and create PR only (skip wizard run) |

mprocs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ procs:
6868

6969
wizard-tail-run:
7070
# Tail the wizard's verbose output
71-
shell: "tail -f \"${POSTHOG_WIZARD_LOG_DIR:-/tmp}/posthog-wizard.log\""
71+
shell: "tail -f /tmp/posthog-wizard.log"
7272
autostart: false
7373
env_file: .env
7474

services/wizard-benchmark/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,12 @@ const PLUGIN_NAMES = [
5555
] as const;
5656

5757
function defaultConfig(): BenchmarkConfig {
58-
const logDir = process.env.POSTHOG_WIZARD_LOG_DIR || "/tmp";
5958
return {
6059
plugins: Object.fromEntries(PLUGIN_NAMES.map((p) => [p, true])),
6160
output: {
6261
benchmarkPath: "/tmp/posthog-wizard-benchmark.json",
6362
benchmarkEnabled: true,
64-
logPath: join(logDir, "posthog-wizard.log"),
63+
logPath: "/tmp/posthog-wizard.log",
6564
logEnabled: true,
6665
suppressWizardLogs: false,
6766
},

0 commit comments

Comments
 (0)