Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates NextJS rewrite configurations to use the new /flags endpoint instead of the deprecated /decide endpoint. The change aligns the documentation and test configurations with the updated API endpoint.
- Updates documentation examples to use
/ingest/flagsinstead of/ingest/decide - Simplifies the test application configuration by removing PostHog-specific rewrites
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nextjs/docs.ts | Updates three NextJS configuration examples to use the new /flags endpoint in rewrite rules |
| e2e-tests/test-applications/nextjs-instrumentation-client-test-app/next.config.ts | Simplifies configuration by removing PostHog rewrites and reverting to basic NextJS config |
Comments suppressed due to low confidence (1)
e2e-tests/test-applications/nextjs-instrumentation-client-test-app/next.config.ts:2
- The removal of PostHog rewrites from the test application configuration may break existing e2e tests that depend on the
/ingest/flagsendpoint being properly routed. Consider adding back the rewrite rules with the updated/flagsendpoint to maintain test coverage.
const nextConfig = {};
daniloc
approved these changes
Jul 23, 2025
Collaborator
daniloc
left a comment
There was a problem hiding this comment.
nice, makes sense to me!
This was referenced Jul 23, 2025
daniloc
pushed a commit
that referenced
this pull request
Oct 27, 2025
* feat: use /flags endpoint * remove packages from example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use the new flags endpoint in rewrite configurations