Conversation
edwinyjlim
reviewed
Nov 25, 2025
Member
edwinyjlim
left a comment
There was a problem hiding this comment.
looks pretty straightforward and it ran fine on my machine
but what about the .github/workflows/publish? I see unpinned pnpm versions here
- name: Install pnpm
run: npm install -g pnpm
- name: Install package.json dependencies with pnpm
run: pnpm install
- name: Build the package
run: pnpm build
- name: Publish the package in the npm registry
run: pnpm publish --access public
Member
Author
|
@edwinyjlim That github action looks at the |
joshsny
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.