feat(e2e-harness): preserve ANSI color in snapshot frames#730
Merged
Conversation
frame() returns plain text (translateToString), which strips the colors — the snapshots are meant to faithfully reproduce the colored CLI. Add frameAnsi(), which serializes the xterm buffer back to ANSI (fg/bg incl. 256-color and truecolor, plus bold/italic/underline/etc.) by reading cell attributes, and have tui-snapshots write .ans frames with it. frame() stays plain for the agent-facing render_screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
Collaborator
Author
|
:colors: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize each captured TUI frame back to ANSI so snapshots preserve the terminal's colors and attributes instead of flattening to plain text.
Snapshots — full real-TUI run, color preserved
Real
--e2erun againstbasic-integration/next-js/15-app-router-todo, every key-moment frame captured throughframeAnsi()and rendered with its color.01-intro (+0s)
02-auth (+1s)
03-run (+2s)
04-run (+3s)
05-outro (+6s)
06-mcp (+7s)
07-slack-connect (+8s)
08-keep-skills (+8s)