feat: make --default the default, and add an --eu flag#81
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the CLI less verbose by flipping the default behavior of the --default flag to enabled and introducing an --eu shorthand for setting the region to EU.
- Flipped
--defaultflag to default totrueand set region default tous - Introduced a new
--euboolean flag and applied override logic in handlers - Updated tests to cover the new flags and enhanced README with MCP commands and revised options table
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/cli.test.ts | Added tests for --default, --eu, and updated region behavior |
| bin.ts | Changed default values, added --eu option, updated handlers |
| README.md | Added “MCP Commands” section and updated CLI options table |
Comments suppressed due to low confidence (2)
src/tests/cli.test.ts:184
- Currently tests only cover
mcp add. Add tests formcp remove(e.g., respecting--eu, default region, and global flags) to ensure both commands behave consistently.
describe('mcp commands', () => {
bin.ts:102
- The
mcp removehandler doesn’t apply the--euoverride likemcp adddoes. Mirror the logic: copyargvinto anoptionsobject, checkargv.eu, setoptions.region = 'eu'if true, then callrunMCPRemove(options…).
);
jonathanlab
approved these changes
Jul 4, 2025
daniloc
pushed a commit
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make the command simpler and less verbose.
Adds tests for the CLI args, since there were not any previously.