Skip to content

feat: make --default the default, and add an --eu flag#81

Merged
joshsny merged 1 commit intomainfrom
make-commands-simpler
Jul 8, 2025
Merged

feat: make --default the default, and add an --eu flag#81
joshsny merged 1 commit intomainfrom
make-commands-simpler

Conversation

@joshsny
Copy link
Copy Markdown
Collaborator

@joshsny joshsny commented Jul 4, 2025

We want to make the command simpler and less verbose.

Adds tests for the CLI args, since there were not any previously.

@joshsny joshsny requested review from a team and Copilot July 4, 2025 15:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the CLI less verbose by flipping the default behavior of the --default flag to enabled and introducing an --eu shorthand for setting the region to EU.

  • Flipped --default flag to default to true and set region default to us
  • Introduced a new --eu boolean flag and applied override logic in handlers
  • Updated tests to cover the new flags and enhanced README with MCP commands and revised options table

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/tests/cli.test.ts Added tests for --default, --eu, and updated region behavior
bin.ts Changed default values, added --eu option, updated handlers
README.md Added “MCP Commands” section and updated CLI options table
Comments suppressed due to low confidence (2)

src/tests/cli.test.ts:184

  • Currently tests only cover mcp add. Add tests for mcp remove (e.g., respecting --eu, default region, and global flags) to ensure both commands behave consistently.
  describe('mcp commands', () => {

bin.ts:102

  • The mcp remove handler doesn’t apply the --eu override like mcp add does. Mirror the logic: copy argv into an options object, check argv.eu, set options.region = 'eu' if true, then call runMCPRemove(options…).
          );

Comment thread bin.ts
@joshsny joshsny merged commit 3904f4f into main Jul 8, 2025
7 checks passed
@joshsny joshsny mentioned this pull request Jul 8, 2025
daniloc pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants