test: Add reproducer of 4622 (negative connection count)

Author: mkleczek

test/observability/Observation/ToxiSpec.hs

@@ -12,6 +12,10 @@ import           Protolude                   hiding (get)
 import           Test.Hspec                  (SpecWith, describe, it)
 import           Test.Hspec.Wai
 import           Toxiproxy                   (withDisabled)
+import Prometheus (getGauge)
+import PostgREST.Metrics (MetricsState(poolAvailable))
+import qualified PostgREST.Metrics as Metric
+import Test.Hspec.Expectations
 
 spec :: SpecWith (SpecState, Application)
 spec = describe "Tests using Toxiproxy" $ do
@@ -32,3 +36,18 @@ spec = describe "Tests using Toxiproxy" $ do
     liftBaseDiscard (withDisabled specToxiProxy) $ do
         void $ get "/items?id=eq.5"
             `shouldRespondWith` 503
+
+  it "Must not have negative connection count" $ do
+    SpecState{specAppState, specToxiProxy, specMetrics=Metric.MetricsState{poolAvailable}} <- getState
+
+    -- make sure there are no open connections
+    liftIO $ AppState.flushPool specAppState
+
+    liftBaseDiscard (withDisabled specToxiProxy) $ do
+        replicateM_ 5 $ get "/authors_only?id=eq.5"
+            `shouldRespondWith` 503
+
+    -- TODO https://github.com/PostgREST/postgrest/issues/4622
+    -- change to 0 when fixed
+    -- HSpec does not support xfail which should be used instead
+    liftIO $ getGauge poolAvailable >>= (`shouldBe` (-5::Int)) . round