nix: add postgrest-with-oriole-17#4845
Conversation
717f0b4 to
50a6046
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6b817d2 to
1b44dfa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1b44dfa to
146115e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
146115e to
5a9fc47
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5a9fc47 to
f1d0e8e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
f1d0e8e to
0150b05
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
0150b05 to
5fa3729
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you. Could we verify there are no known issues on OrioleDB's side? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5fa3729 to
9c079fc
Compare
After doing that, only a few tests fail where we hardcoded a certain expectation of cost. The cost changed because a different plan was chosen - instead of "Seq Scan" it uses "Custom Scan": The query should essentially be a simple PG 17: Oriole: |
|
There's one more thing that fails, which is the build on MacOS. I tracked the error message down to the thread that resulted in postgres/postgres@0dceba2, which does not seem to be present in |
9c079fc to
7b8048e
Compare
Looking at this some more makes me wonder whether the regular Seq Scan has just associated increased cost estimations now - and that's why the index scan is chosen in this case? Any idea, @akorotkov? |
|
@wolfgangwalther, OrioleDB implements index-organized tables. Even if there is no primary key, OrioleDB organizes the table as an index over an invisible CTID column. It has an equivalent to seq scan, but it's internally different and has a different estimate. |
7b8048e to
cb272f3
Compare
Thanks - that's what I suspected. So the different cost estimates / plans in this case are OK. I already tried building on MacOS - works now. This means we have all test failures figured out, no questions remain. (can't merge this before we sort out packaging issues in Nixpkgs, though) |
cb272f3 to
2755a26
Compare
Tests PostgREST against orioledb, which is packaged on a temporary branch on my Nixpkgs fork. Thus, not ready for merging, yet.
We will be able to see some failing spec tests, though - did not check the other test suites, yet.
Open issues:
SELECTwithANYclause uses a more costly custom/index scan in orioledb. It's questionable whether that's a bug or whether we'd just need to special case the cost estimation here.