refactor: remove auth and logging middleware#4884
Merged
steve-chavez merged 1 commit intoMay 7, 2026
Merged
Conversation
steve-chavez
force-pushed
the
remove-middleware-auth-logger
branch
from
57aef68 to
403b1c6
Compare
2 tasks
steve-chavez
commented
May 6, 2026
mkleczek
reviewed
May 6, 2026
mkleczek
reviewed
May 6, 2026
taimoorzaeem
reviewed
May 6, 2026
taimoorzaeem
reviewed
May 6, 2026
mkleczek
reviewed
May 6, 2026
steve-chavez
force-pushed
the
remove-middleware-auth-logger
branch
7 times, most recently
from
2e468b7 to
fe8f1ea
Compare
taimoorzaeem
reviewed
May 7, 2026
This commit removes auth middleware for it hides side effects and obscures logic. The auth operations are now done in its own stage in the request-response cycle. It also removes the logging middleware because now we instead use observation module to log the response.
steve-chavez
force-pushed
the
remove-middleware-auth-logger
branch
from
fe8f1ea to
5359769
Compare
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #4064 and #4062.
I think it's important to do this now before #3140, otherwise we'll accumulate tech debt. It should also make #4831 easier to do.
Benefits: