test: consistently analyze tables exactly once#4930
Merged
wolfgangwalther merged 2 commits intoMay 17, 2026
Conversation
wolfgangwalther
force-pushed
the
analyze-spec-tests
branch
from
6d7c269 to
0b703b0
Compare
wolfgangwalther
force-pushed
the
analyze-spec-tests
branch
from
0b703b0 to
2fe5830
Compare
steve-chavez
approved these changes
May 17, 2026
Member
steve-chavez
left a comment
steve-chavez
left a comment
There was a problem hiding this comment.
Don't get why coverage fails, but overall looks good to me.
wolfgangwalther
force-pushed
the
analyze-spec-tests
branch
from
2fe5830 to
c693df0
Compare
Member
Author
It passes locally for me, let's see what a fresh rebase / push does. |
Member
Author
Actually it does not. It fails on the big schema step, erroring out with |
This is easier to reason about and easier to extend. Also removes a tiny bit of repetition.
Disabling the autovacuum daemon should also help reproducibility in theory, although I don't know of any cases where we hit a problem with that. VACUUM changes the order of rows that PostgreSQL returns for some table without explicit ordering, thus doing the latter to make it consistently reproducible. After ANALYZE estimates are 100% exact for the moment, so some requests which returned 206 Partial Response now return 200 instead. The fact that PostgREST returns 206 on an unfiltered endpoint can probably be considered a bug.
wolfgangwalther
force-pushed
the
analyze-spec-tests
branch
from
c693df0 to
45cd8dd
Compare
Member
Author
|
Fixed a typo, coverage is good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up as mentioned in #4845 (comment).
TODO: