refactor(remove): schema cache load delay config#4936
Conversation
mkleczek
force-pushed
the
push-qnyopwtqmxpo
branch
2 times, most recently
from
aa24116 to
8916abb
Compare
@mkleczek Can you please stop adding that paragraph? We agreed before that those disclaimers are not necessary, I have to review multiple PRs and that is not making the job easier. |
From what I understood the problem was with the disclaimer in the commit message - not in the PR description, no? |
On the PR description it makes the job of reviewing multiple PRs a day more tiring, I have to ignore a part of the description for some and look everything in others. But anyway, many thanks for correcting this on #4937 🙇♂️ Let's merge #4937 first since it proves this delay is not needed. |
mkleczek
force-pushed
the
push-qnyopwtqmxpo
branch
2 times, most recently
from
f68efed to
2b83ab2
Compare
|
One thing I'm not sure about is the commit prefix: postgrest/nix/tools/gitTools.nix Line 22 in 6220ab3 Since this doesn't remove any user facing fix or feature, perhaps it should be a |
Agree, I would do it like |
|
Cool. @mkleczek Please change the prefix commit like the one mentioned above, then I'll merge. |
Remove internal schema cache load and relationship load sleep settings plus the delay wrappers they enabled. Drop IO tests that depended on the removed settings.
mkleczek
force-pushed
the
push-qnyopwtqmxpo
branch
from
2b83ab2 to
d33a054
Compare
mkleczek
changed the title
Done |
3 participants
Remove internal schema cache load and relationship load sleep settings plus
the delay wrappers they enabled. Drop IO tests that depended on the removed
settings.
See: #4873 (comment)
DISCLAIMER:
This commit was authored entirely by a human without the assistance of LLMs.