v14: refactor: Simplify App.initServerSocket#4953
Closed
taimoorzaeem wants to merge 1 commit into
Closed
Conversation
This change gets rid of unnecessary explicit bindRandomPortTCP in initServerSocket. Returned port value was ignored in removed code anyway as assigned port retrieval from an open socket is handled elsewhere.
steve-chavez
approved these changes
May 25, 2026
steve-chavez
requested changes
May 25, 2026
Member
steve-chavez
left a comment
steve-chavez
left a comment
There was a problem hiding this comment.
Hm, hold on. I think we agreed that refactor commits are high risk to backport.
Are you doing this to merge #4880 later? I think we should leave that one for a new version to be safe.
Member
Author
Yes, we did agree on that. I realize now that we shouldn't do it prematurely.
Right. Closing this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1a6ba20.