test(spec): inline config into test suite#4965
Merged
Merged
Conversation
These are now part of the with- helpers.
Everything that uses withApp is in that list.
Member
Agree, looks good. |
wolfgangwalther
force-pushed
the
test-spec-config
branch
from
94afec7 to
ee115ae
Compare
Member
Author
|
I inlined all the configurations into the spec files. Of course, further simplification and restructuring could follow this up, we have some test suites that could easily be merged into a single file again, for example the different OpenAPI cases etc. - but that's beyond the scope of this PR. |
wolfgangwalther
force-pushed
the
test-spec-config
branch
from
ee115ae to
ea4b834
Compare
Previously, information about each test-suite was repeated in 3 separate places: - as a label and as implicit knowledge in the test-suite itself, - as a comment in Main.hs, and - as a configuration in SpecHelper.hs. With this change, there will be a single source of truth in the test suite itself. This will allow a single test-suite to easily test multiple different configurations.
This was brought over in the last commit, because the postgis was re-using the same config as another test. Now it has a separate config, so we can reduce it a bit.
wolfgangwalther
force-pushed
the
test-spec-config
branch
from
ea4b834 to
a30199a
Compare
steve-chavez
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, information about each test-suite was repeated in 3 separate places:
With this change, there will be a single source of truth in the test suite itself. This will allow a single test-suite to easily test multiple different configurations.
PoC with a single test-suite changed. Should be extended to all others before merge, if we agree on this.
Helps with #4946 (comment).