Skip to content

chore: sort config dump alphabetically#4972

Merged
wolfgangwalther merged 1 commit into
PostgREST:mainfrom
netqo:chore/config-dump-ordering
Jun 2, 2026
Merged

chore: sort config dump alphabetically#4972
wolfgangwalther merged 1 commit into
PostgREST:mainfrom
netqo:chore/config-dump-ordering

Conversation

@netqo
Copy link
Copy Markdown
Contributor

@netqo netqo commented Jun 2, 2026

Closes #4769

The config dump in Config.hs listed db-config, db-pre-config and the db-pool-* settings out of alphabetical order, while the rest of the dump was sorted. This reorders the pgrstSettings list in src/PostgREST/Config.hs so the entire dump is consistently alphabetical, and updates the expected IO test configs to match.

Tested with postgrest-test-io -k config and postgrest-style.

@netqo
Copy link
Copy Markdown
Contributor Author

netqo commented Jun 2, 2026

I went with strict alphabetical order since the dump was already mostly alphabetical so it felt like the most consistent/self-contained fix. Happy to switch to the docs order instead if you'd rather have that >.<

Comment thread src/PostgREST/Config.hs Outdated
The config dump in Config.hs listed db-config, db-pre-config and the
db-pool-* settings out of alphabetical order, while the rest of the dump
was sorted. Now the whole dump is consistently alphabetical and update
the expected IO test configs to match.
@netqo netqo force-pushed the chore/config-dump-ordering branch from 5645b2e to 3674bff Compare June 2, 2026 06:41
@netqo
Copy link
Copy Markdown
Contributor Author

netqo commented Jun 2, 2026

Done, switched to sort as you suggested!! thnksies🥺

@wolfgangwalther wolfgangwalther merged commit 097a1de into PostgREST:main Jun 2, 2026
31 checks passed
@taimoorzaeem
Copy link
Copy Markdown
Member

@netqo Thanks for the PR!

@netqo netqo deleted the chore/config-dump-ordering branch June 2, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

chore: config dump is slightly out of order

3 participants