nix(loadtest): run all target branches almost at the same time#5052
Merged
wolfgangwalther merged 4 commits intoJun 27, 2026
Merged
Conversation
No need to duplicate this code, all of it is right there.
I'm not sure whether anyone is actually using them, but they never worked really well, I believe. We should add something based on an existing pre-commit hook manager, not that brittle custom thing we have. Allows me to remove postgrest-with-git in the next commit instead of duplicating it.
Instead of building, running, building, running, ... we now build all executables once ahead of time and then run all loadtests right after each other. This can sometimes reduce noise when load on the GHA runner varies over time. Since this requires us to move building into the loadtest-against script, it also allows to go back to have the regular postgrest-loadtest command default to building with cabal for faster local iteration.
Instead of generating them at loadtest runtime, we generate these dynamic targets once via Nix. Because we're using libfaketime, we're not bound to doing it at the same time as running the tests. This allows us to run each loadtest right after each other, with minimal other stuff going on inbetween. It's also a tiny bit more reproducible, because the loadtests against both branches run with exactly the same set of targets, where they did not before.
wolfgangwalther
force-pushed
the
loadtest-against-build-once
branch
from
99046de to
cb406e1
Compare
steve-chavez
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of building, running, building, running, ... we now build all executables once ahead of time and then run all loadtests right after each other. This can sometimes reduce noise when load on the GHA runner varies over time.
(a few more less meaningful commits around that as well)