Skip to content

Commit f3d9913

Browse files
committed
Annotate cases where we build DNSZoneRecord with domain_id not known.
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
1 parent 0b3ef16 commit f3d9913

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

pdns/dnsproxy.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ void DNSProxy::mainloop()
318318
dzr.dr.d_ttl = answer.d_ttl;
319319
dzr.dr.d_place = answer.d_place;
320320
dzr.dr.setContent(answer.getContent());
321+
// NOTE dzr.domain_id == UnknownDomainID
321322
iter->second.complete->addRecord(std::move(dzr));
322323
}
323324
}

pdns/packethandler.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ int PacketHandler::doChaosRequest(const DNSPacket& p, std::unique_ptr<DNSPacket>
325325
rr.dr.d_name=target;
326326
rr.dr.d_type=QType::TXT;
327327
rr.dr.d_class=QClass::CHAOS;
328+
// NOTE rr.domain_id == UnknownDomainID
328329
r->addRecord(std::move(rr));
329330
return 1;
330331
}

pdns/stubresolver.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ int stubDoResolve(Logr::log_t slog, const DNSName& qname, uint16_t qtype, vector
186186
DNSZoneRecord zrr;
187187
zrr.dr = answer;
188188
zrr.auth = true;
189+
// NOTE zrr.domain_id == UnknownDomainID
189190
ret.push_back(std::move(zrr));
190191
}
191192
}

pdns/tkey.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ void PacketHandler::tkeyHandler(const DNSPacket& p, std::unique_ptr<DNSPacket>&
115115
zrr.dr.d_class = QClass::ANY;
116116
zrr.dr.setContent(std::move(tkey_out));
117117
zrr.dr.d_place = DNSResourceRecord::ANSWER;
118+
// NOTE zrr.domain_id == UnknownDomainID
118119
r->addRecord(std::move(zrr));
119120

120121
#ifdef ENABLE_GSS_TSIG

0 commit comments

Comments
 (0)