Auth: nested catalogs#16971
Merged
Merged
Conversation
miodvallat
reviewed
Mar 12, 2026
93b84fa to
3827d01
Compare
miodvallat
reviewed
Mar 12, 2026
3827d01 to
c011f55
Compare
miodvallat
reviewed
Mar 12, 2026
c011f55 to
5e65222
Compare
miodvallat
reviewed
Mar 12, 2026
5e65222 to
407c697
Compare
Habbie
reviewed
Apr 23, 2026
Member
Habbie
left a comment
There was a problem hiding this comment.
Code looks good. Perhaps the docs on catalog zones should explain a bit how the groups work?
One nit. One test breakage (repeated in many places).
407c697 to
df5ea79
Compare
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
df5ea79 to
c6c88c1
Compare
miodvallat
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
"One catalog to rule them all"
Make it possible for catalog zones to be a member of an other catalog. A group property is used to signal if a member is a catalog.
And one commit to unbreak the regression tests for dynmodules.
Checklist
I have: