Skip to content

Auth: nested catalogs#16971

Merged
miodvallat merged 3 commits into
PowerDNS:masterfrom
mind04:auth-nested-catalogs
Apr 24, 2026
Merged

Auth: nested catalogs#16971
miodvallat merged 3 commits into
PowerDNS:masterfrom
mind04:auth-nested-catalogs

Conversation

@mind04
Copy link
Copy Markdown
Contributor

@mind04 mind04 commented Mar 11, 2026

Short description

"One catalog to rule them all"

Make it possible for catalog zones to be a member of an other catalog. A group property is used to signal if a member is a catalog.

And one commit to unbreak the regression tests for dynmodules.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
Comment thread pdns/auth-secondarycommunicator.cc Outdated
@mind04 mind04 force-pushed the auth-nested-catalogs branch from 93b84fa to 3827d01 Compare March 12, 2026 13:01
Comment thread modules/lmdbbackend/lmdbbackend.cc Outdated
@mind04 mind04 force-pushed the auth-nested-catalogs branch from 3827d01 to c011f55 Compare March 12, 2026 13:26
Comment thread pdns/backends/gsql/gsqlbackend.cc Outdated
@mind04 mind04 force-pushed the auth-nested-catalogs branch from c011f55 to 5e65222 Compare March 12, 2026 13:44
Comment thread pdns/auth-secondarycommunicator.cc Fixed
Comment thread pdns/auth-secondarycommunicator.cc Fixed
Comment thread pdns/auth-secondarycommunicator.cc Outdated
@mind04 mind04 force-pushed the auth-nested-catalogs branch from 5e65222 to 407c697 Compare March 12, 2026 17:54
@mind04 mind04 requested a review from miodvallat April 21, 2026 09:26
@Habbie Habbie added this to the auth-5.1 milestone Apr 23, 2026
Copy link
Copy Markdown
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Perhaps the docs on catalog zones should explain a bit how the groups work?

One nit. One test breakage (repeated in many places).

Comment thread docs/settings.rst Outdated
Comment thread regression-tests/backends/gsqlite3-master Outdated
@mind04 mind04 force-pushed the auth-nested-catalogs branch from 407c697 to df5ea79 Compare April 24, 2026 07:23
mind04 added 3 commits April 24, 2026 11:43
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
Signed-off-by: Kees Monshouwer <mind04@monshouwer.org>
@mind04 mind04 force-pushed the auth-nested-catalogs branch from df5ea79 to c6c88c1 Compare April 24, 2026 09:58
@miodvallat miodvallat merged commit d85ab45 into PowerDNS:master Apr 24, 2026
91 checks passed
@mind04 mind04 deleted the auth-nested-catalogs branch April 24, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants