Skip to content

dnsdist: Remove autotools#17010

Merged
rgacogne merged 10 commits into
PowerDNS:masterfrom
pieterlexis:dnsdist-rm-autotool
May 29, 2026
Merged

dnsdist: Remove autotools#17010
rgacogne merged 10 commits into
PowerDNS:masterfrom
pieterlexis:dnsdist-rm-autotool

Conversation

@pieterlexis
Copy link
Copy Markdown
Contributor

Short description

As part of removing some technical debt, this PR removes the possibility to build dnsdist using autotools.

Draft PR to iron out all the CI issues.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch 4 times, most recently from 737255a to 2092b6e Compare March 19, 2026 13:53
pieterlexis added a commit to pieterlexis/oss-fuzz that referenced this pull request Mar 19, 2026
pieterlexis added a commit to pieterlexis/oss-fuzz that referenced this pull request Mar 19, 2026
@rgacogne rgacogne added this to the dnsdist-2.2.0 milestone Mar 20, 2026
@omoerbeek
Copy link
Copy Markdown
Member

From build_and_test_all.yml:

env:
  ...
  BUILDER_VERSION: '0.0.0-git1'
  ...

The codeql-analysis.yml workflow does not seem to have anything like that.

@pieterlexis
Copy link
Copy Markdown
Contributor Author

I wonder why the codeql one does not have that and it does work for the autotools build.

@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 48753e6 to 8f42213 Compare March 23, 2026 09:00
pieterlexis added a commit to pieterlexis/oss-fuzz that referenced this pull request Mar 23, 2026
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Mar 23, 2026
This should fix the Fuzz errors in
PowerDNS/pdns#17010

---------

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
Co-authored-by: Remi Gacogne <remi.gacogne@powerdns.com>
@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from d850bf5 to 3279417 Compare March 23, 2026 16:15
@rgacogne
Copy link
Copy Markdown
Member

Ah, looks like we might have to add python-yaml to the oss-fuzz environment, or perhaps disable YAML support there?

@pieterlexis
Copy link
Copy Markdown
Contributor Author

Ah, looks like we might have to add python-yaml to the oss-fuzz environment, or perhaps disable YAML support there?

I think we should keep yaml in the fuzz build, should we ever want to fuzz the parser?

@rgacogne
Copy link
Copy Markdown
Member

That requires building the Rust-based static library, so we need a Rust compiler. So perhaps it makes sense to not do that for now, and cross that bridge if we decide to fuzz serde (which would probably not happen in dnsdist anyway)?

@pieterlexis
Copy link
Copy Markdown
Contributor Author

you're right, let's disable it.

@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 3279417 to 241de62 Compare April 9, 2026 07:43
@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch 2 times, most recently from b6b6aec to 74cfcd1 Compare May 26, 2026 10:20
@rgacogne
Copy link
Copy Markdown
Member

google/oss-fuzz#15546 will help with the fuzzing issues, and I opened pieterlexis#18 to simplify a bit the handling of dnsdist's fuzzing targets.

@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 5d24c2a to c93958e Compare May 27, 2026 12:34
@pieterlexis pieterlexis requested a review from rgacogne May 27, 2026 13:46
@pieterlexis pieterlexis marked this pull request as ready for review May 27, 2026 13:46
Comment thread .github/workflows/build-and-test-all.yml Outdated
@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 8bfe756 to b2c008c Compare May 28, 2026 08:52
@coveralls
Copy link
Copy Markdown

coveralls commented May 28, 2026

Coverage Report for CI Build 26573471660

Coverage increased (+4.0%) to 71.023%

Details

  • Coverage increased (+4.0%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 104 coverage regressions across 15 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

104 previously-covered lines in 15 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
pdns/snmp-agent.cc 32 63.64%
pdns/dnsdistdist/dnsdist-snmp.cc 28 55.29%
pdns/recursordist/test-syncres_cc1.cc 8 80.08%
pdns/dnsdistdist/dnsdist-carbon.cc 7 59.8%
modules/godbcbackend/sodbc.cc 4 69.31%
pdns/auth-secondarycommunicator.cc 4 58.03%
pdns/communicator.cc 3 63.46%
pdns/dnsdistdist/dnsdist-healthchecks.cc 3 54.55%
pdns/iputils.cc 3 58.52%
pdns/logging.cc 3 80.23%

Coverage Stats

Coverage Status
Relevant Lines: 170516
Covered Lines: 132676
Line Coverage: 77.81%
Relevant Branches: 81426
Covered Branches: 46262
Branch Coverage: 56.81%
Branches in Coverage %: Yes
Coverage Strength: 6331574.7 hits per line

💛 - Coveralls

@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 4c157c5 to 15de42c Compare May 28, 2026 10:41
@pieterlexis pieterlexis force-pushed the dnsdist-rm-autotool branch from 690cd49 to 5f26cd7 Compare May 28, 2026 12:02
@pieterlexis pieterlexis requested a review from rgacogne May 28, 2026 15:17
Copy link
Copy Markdown
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@rgacogne rgacogne merged commit 82597ea into PowerDNS:master May 29, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants