Skip to content

dnsdist-2.1: Backport 17381 - Fix DownstreamState::setHealthCheckParams#17413

Merged
rgacogne merged 3 commits into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17381
May 21, 2026
Merged

dnsdist-2.1: Backport 17381 - Fix DownstreamState::setHealthCheckParams#17413
rgacogne merged 3 commits into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17381

Conversation

@rgacogne
Copy link
Copy Markdown
Member

@rgacogne rgacogne commented May 19, 2026

Short description

Backport #17381 to dnsdist-2.1.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

rgacogne added 2 commits May 19, 2026 11:00
@rgacogne
dnsdist: Fix DownstreamState::setHealthCheckParams
1450794 
We cannot rely on the value of the variable being different from 0
since we reuse it for all options.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 881da6d)
@rgacogne
dnsdist: Fix a bug caught by clang-tidy
0e9f648 
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit cab10e6)
@rgacogne rgacogne added this to the dnsdist-2.1.0 milestone May 19, 2026
@rgacogne
dnsdist: Hopefully fixes spurious failures of TestHealthCheckLatency
2b33431 
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 1a8b7bf)
@rgacogne rgacogne merged commit 793eb1f into PowerDNS:rel/dnsdist-2.1.x May 21, 2026
19 checks passed
@rgacogne rgacogne deleted the ddist21-backport-17381 branch May 21, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miodvallat miodvallat miodvallat approved these changes

Assignees

No one assigned

Labels

defect dnsdist

Projects

None yet

Milestone

dnsdist-2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rgacogne @miodvallat