dnsdist-2.1: Backport 17380 - Fix OPT rdlen computation when adding ECS#17436
Merged
rgacogne merged 1 commit intoMay 21, 2026
Merged
Conversation
If an incoming query has a very large EDNS OPT rdata length, but not the corresponding bytes, the existing code could have wrapped around to a small value after adding ECS. We would then send an invalid OPT record with some trailing bytes. The query would have been discarded by the backend but that's not very nice, let's drop it early AND make sure we don't wrap around. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com> (cherry picked from commit 5041ad7)
miodvallat
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Backport #17380 to dnsdist-2.1.x
Checklist
I have: