Skip to content

change to release env#6

Merged
TonyXiang8787 merged 13 commits into
mainfrom
pgm/sync-version-to-release-env
Jul 6, 2026
Merged

change to release env#6
TonyXiang8787 merged 13 commits into
mainfrom
pgm/sync-version-to-release-env

Conversation

@nitbharambe

@nitbharambe nitbharambe commented Jun 29, 2026

Copy link
Copy Markdown
Member

Was correctly failing at the moment: https://github.com/PowerGridModel/homebrew-pgm/actions/runs/28345856219/job/83968911173
(And workflow dispatch on this branch too fails as expected)

  • Changed action sha from master to latest release
  • Restricted auto-commit to only formula

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Comment thread .github/workflows/sync-version.yml Outdated
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe nitbharambe marked this pull request as ready for review June 29, 2026 09:38
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe

nitbharambe commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Meant to ask PowerGridModel/pgm-build-deps#6 (comment) here: Should we revist decision to make PR instead of auto commit.
I realise that this is the standard way to auto commit the formula.

I imagine this would address the concern I mentioned: b74d2eb

figueroa1395
figueroa1395 previously approved these changes Jun 29, 2026

@figueroa1395 figueroa1395 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice additional security steps you added. Learned some cool things.

Comment thread .github/workflows/sync-version.yml
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

@mgovers mgovers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvements

Comment thread .github/workflows/sync-version.yml
@TonyXiang8787

Copy link
Copy Markdown
Member

I just tried to compile this. It will not work. Maybe the formula does not work for a long time.

@nitbharambe you need to add the actual brew compile and test in the CI before actually push the new formula.

The current one is broken...

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@figueroa1395

Copy link
Copy Markdown
Member

@nitbharambe this is blocked until #7 is merged, right?

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe

Copy link
Copy Markdown
Member Author

Both #7 and this PR are ready.
The changes in formula / template are common. Not required but it would be better to merge #7 first.

@figueroa1395

Copy link
Copy Markdown
Member

Both #7 and this PR are ready.
The changes in formula / template are common. Not required but it would be better to merge #7 first.

@nitbharambe Let's merge #7 first so we have everything properly tested first.

Also, do you prefer to scope out the open comments as a later improvement?

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the base branch from main to pgm/feature/test-formula-in-pr July 6, 2026 09:01
…o-release-env

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Base automatically changed from pgm/feature/test-formula-in-pr to main July 6, 2026 11:16
@TonyXiang8787 TonyXiang8787 merged commit a5c8adf into main Jul 6, 2026
2 checks passed
@TonyXiang8787 TonyXiang8787 deleted the pgm/sync-version-to-release-env branch July 6, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants