change to release env#6
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
Meant to ask PowerGridModel/pgm-build-deps#6 (comment) here: Should we revist decision to make PR instead of auto commit. I imagine this would address the concern I mentioned: b74d2eb |
figueroa1395
left a comment
There was a problem hiding this comment.
Pretty nice additional security steps you added. Learned some cool things.
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
I just tried to compile this. It will not work. Maybe the formula does not work for a long time. @nitbharambe you need to add the actual brew compile and test in the CI before actually push the new formula. The current one is broken... |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
@nitbharambe this is blocked until #7 is merged, right? |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe Let's merge #7 first so we have everything properly tested first. Also, do you prefer to scope out the open comments as a later improvement? |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…o-release-env Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Was correctly failing at the moment: https://github.com/PowerGridModel/homebrew-pgm/actions/runs/28345856219/job/83968911173
(And workflow dispatch on this branch too fails as expected)
masterto latest release