feat(graph): add bfs#274
Open
vincentkoppen wants to merge 6 commits into
Open
Conversation
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
vincentkoppen
commented
Jun 16, 2026
Signed-off-by: Vincent Koppen <53343926+vincentkoppen@users.noreply.github.com>
|
| source(int | Sequence[int]): the source(s) the start the breadth first search from. | ||
|
|
||
| Returns: | ||
| list[tuple[int, int | None]]: the (node, parent) by the order in which we found the nodes. |
There was a problem hiding this comment.
For this and the dfs PR: is it most natural to return (node, parent) or (parent, node)? For me the latter feels more easily to follow as you travel from parent to child
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #161
(First) implementation of bfs, please give feedback if anything is missing
Updated: now returns a list of (node, parent)