Skip to content

Pipeline fixes#422

Merged
Power-Maverick merged 4 commits into
mainfrom
pipeline-fixes
Mar 2, 2026
Merged

Pipeline fixes#422
Power-Maverick merged 4 commits into
mainfrom
pipeline-fixes

Conversation

@Power-Maverick

@Power-Maverick Power-Maverick commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Follow the guidelines from the CONTRIBUTING.md.
  • Mention the bug or the feature number the PR will be targeting.
  • Test the change in your own code. (Compile and run)
  • Resolve all GH Copilot comments.

Copilot AI review requested due to automatic review settings March 2, 2026 02:54
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown

Bundle Size Report 📦

Bundle Size
Main Process 4.86 MB
Renderer JS 696.6 KB
Renderer CSS 76.96 KB
Total 5.62 MB

Bundle Analysis Reports

The detailed bundle analysis reports are available in the workflow artifacts:

  • 📊 Main Process: stats-main.html
  • 📊 Renderer Process: stats-renderer.html

Download the artifacts from the workflow run to view interactive visualizations.


Bundle size tracking is now active! This helps prevent bundle bloat.

@Power-Maverick Power-Maverick merged commit f5cc586 into main Mar 2, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions release/publish workflows to improve package publishing and release artifact metadata generation for multi-architecture builds.

Changes:

  • Configure npm registry explicitly in the reusable publish-npm-types workflow.
  • Add a preflight check to ensure @pptb/types version aligns with the desktop app version for stable releases.
  • Update stable + nightly release workflows to merge per-arch macOS/Windows “latest” YAML metadata into single files and switch nightly version suffix from dev to beta.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish-npm-types.yml Adds npm registry configuration during Node setup for publishing @pptb/types.
.github/workflows/prod-release.yml Adds version alignment preflight check; merges macOS/Windows per-arch update YAML metadata into consolidated files.
.github/workflows/nightly-release.yml Switches insider version suffix to beta; merges macOS/Windows per-arch update YAML metadata into consolidated files.
Comments suppressed due to low confidence (3)

.github/workflows/prod-release.yml:629

  • In the macOS latest-mac.yml merge step, VERSION can become an empty string when no existing YAML is found because the if ...; fi compound command exits successfully even when the condition is false, so the || echo "unknown" fallback won’t run. This can produce a latest-mac.yml with a blank version. Set VERSION explicitly when $EXISTING_YML is empty (e.g., use an else branch) or derive it from package.json to ensure it’s always populated.
                  # Find any existing YAML to extract version
                  EXISTING_YML=$(find notarize -name "latest*.yml" -o -name "*-mac.yml" | head -n 1)
                  VERSION=$(if [ -n "$EXISTING_YML" ]; then awk '/^version:[[:space:]]*/ {print $2; exit}' "$EXISTING_YML"; fi 2>/dev/null || echo "unknown")

                  echo "Version: $VERSION"

.github/workflows/prod-release.yml:610

  • This fallback path uses grep -oP ..., but -P (PCRE) isn’t supported by the default BSD grep on macos-latest runners. If this branch executes, the workflow will fail to extract the version. Use a portable alternative (e.g., awk/sed/perl) for parsing instead of grep -P.
                      if [[ -n "$YML_FILES" ]]; then
                          for YML_FILE in $YML_FILES; do
                              VERSION=$(grep -oP 'version:\s+\K[^\s]+' "$YML_FILE" || echo "unknown")
                                ZIP_FILE=$(find "$(dirname "$YML_FILE")" -maxdepth 1 -name "*.zip" | head -n 1)
                                if [[ -n "$ZIP_FILE" && -f "$ZIP_FILE" ]]; then

.github/workflows/nightly-release.yml:635

  • This fallback path uses grep -oP ..., but -P (PCRE) isn’t supported by the default BSD grep on macos-latest runners. If this branch executes, the workflow will fail to extract the version. Use a portable alternative (e.g., awk/sed/perl) for parsing instead of grep -P.
                      if [[ -n "$YML_FILES" ]]; then
                          for YML_FILE in $YML_FILES; do
                              VERSION=$(grep -oP 'version:\s+\K[^\s]+' "$YML_FILE" || echo "unknown")
                                ZIP_FILE=$(find "$(dirname "$YML_FILE")" -maxdepth 1 -name "*.zip" | head -n 1)
                                if [[ -n "$ZIP_FILE" && -f "$ZIP_FILE" ]]; then

@Power-Maverick Power-Maverick deleted the pipeline-fixes branch April 3, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants