Pipeline fixes#422
Merged
Merged
Conversation
…s and macOS YAML files, and update versioning scheme
…on release YAML files
Bundle Size Report 📦
Bundle Analysis ReportsThe detailed bundle analysis reports are available in the workflow artifacts:
Download the artifacts from the workflow run to view interactive visualizations. Bundle size tracking is now active! This helps prevent bundle bloat. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions release/publish workflows to improve package publishing and release artifact metadata generation for multi-architecture builds.
Changes:
- Configure npm registry explicitly in the reusable
publish-npm-typesworkflow. - Add a preflight check to ensure
@pptb/typesversion aligns with the desktop app version for stable releases. - Update stable + nightly release workflows to merge per-arch macOS/Windows “latest” YAML metadata into single files and switch nightly version suffix from
devtobeta.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/publish-npm-types.yml |
Adds npm registry configuration during Node setup for publishing @pptb/types. |
.github/workflows/prod-release.yml |
Adds version alignment preflight check; merges macOS/Windows per-arch update YAML metadata into consolidated files. |
.github/workflows/nightly-release.yml |
Switches insider version suffix to beta; merges macOS/Windows per-arch update YAML metadata into consolidated files. |
Comments suppressed due to low confidence (3)
.github/workflows/prod-release.yml:629
- In the macOS latest-mac.yml merge step, VERSION can become an empty string when no existing YAML is found because the
if ...; ficompound command exits successfully even when the condition is false, so the|| echo "unknown"fallback won’t run. This can produce a latest-mac.yml with a blank version. Set VERSION explicitly when$EXISTING_YMLis empty (e.g., use anelsebranch) or derive it frompackage.jsonto ensure it’s always populated.
# Find any existing YAML to extract version
EXISTING_YML=$(find notarize -name "latest*.yml" -o -name "*-mac.yml" | head -n 1)
VERSION=$(if [ -n "$EXISTING_YML" ]; then awk '/^version:[[:space:]]*/ {print $2; exit}' "$EXISTING_YML"; fi 2>/dev/null || echo "unknown")
echo "Version: $VERSION"
.github/workflows/prod-release.yml:610
- This fallback path uses
grep -oP ..., but-P(PCRE) isn’t supported by the default BSDgrepon macos-latest runners. If this branch executes, the workflow will fail to extract the version. Use a portable alternative (e.g.,awk/sed/perl) for parsing instead ofgrep -P.
if [[ -n "$YML_FILES" ]]; then
for YML_FILE in $YML_FILES; do
VERSION=$(grep -oP 'version:\s+\K[^\s]+' "$YML_FILE" || echo "unknown")
ZIP_FILE=$(find "$(dirname "$YML_FILE")" -maxdepth 1 -name "*.zip" | head -n 1)
if [[ -n "$ZIP_FILE" && -f "$ZIP_FILE" ]]; then
.github/workflows/nightly-release.yml:635
- This fallback path uses
grep -oP ..., but-P(PCRE) isn’t supported by the default BSDgrepon macos-latest runners. If this branch executes, the workflow will fail to extract the version. Use a portable alternative (e.g.,awk/sed/perl) for parsing instead ofgrep -P.
if [[ -n "$YML_FILES" ]]; then
for YML_FILE in $YML_FILES; do
VERSION=$(grep -oP 'version:\s+\K[^\s]+' "$YML_FILE" || echo "unknown")
ZIP_FILE=$(find "$(dirname "$YML_FILE")" -maxdepth 1 -name "*.zip" | head -n 1)
if [[ -n "$ZIP_FILE" && -f "$ZIP_FILE" ]]; then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.