address copilot feedback

Author: Steve Lee (POWERSHELL HE/HIM) (from Dev Box)

dsc/tests/dsc_extension_discover.tests.ps1

@@ -164,11 +164,11 @@ Describe 'Discover extension tests' {
 '@
         $resourceScript = @'
         $resource = @{
-            manifestPath = "$env:TestDrive" + [System.IO.Path]::DirectorySeparatorChar + 'invalidManifest.dsc.json'
+            manifestPath = "$env:TestDrive" + [System.IO.Path]::DirectorySeparatorChar + 'invalidManifest.dsc.resource.json'
         }
         $resource | ConvertTo-Json -Compress
 '@
-        $extendionManifest = @'
+        $extensionManifest = @'
 {
     "$schema": "https://aka.ms/dsc/schemas/v3/bundled/resource/manifest.json",
     "type": "Test/DiscoverInvalid",
@@ -187,9 +187,9 @@ Describe 'Discover extension tests' {
 }
 '@
 
-        Set-Content -Path "$TestDrive/invalidManifest.dsc.json" -Value $invalidManifest
+        Set-Content -Path "$TestDrive/invalidManifest.dsc.resource.json" -Value $invalidManifest
         Set-Content -Path "$TestDrive/discover.ps1" -Value $resourceScript
-        Set-Content -Path "$TestDrive/extension.dsc.extension.json" -Value $extendionManifest
+        Set-Content -Path "$TestDrive/extension.dsc.extension.json" -Value $extensionManifest
         try {
             $env:DSC_RESOURCE_PATH = $TestDrive + [System.IO.Path]::PathSeparator + $env:PATH
             $env:TestDrive = $TestDrive
@@ -199,7 +199,7 @@ Describe 'Discover extension tests' {
             foreach ($resource in $out) {
                 $resource.type | Should -Not -Be 'Test/InvalidManifest'
             }
-            (Get-Content -Path "$TestDrive/error.log" -Raw) | Should -BeLike "*Failed to load manifest '*invalidManifest.dsc.json':*" -Because (Get-Content -Path "$TestDrive/error.log" -Raw | Out-String)
+            (Get-Content -Path "$TestDrive/error.log" -Raw) | Should -BeLike "*Extension 'Test/DiscoverInvalid' failed to load manifest '*invalidManifest.dsc.resource.json':*" -Because (Get-Content -Path "$TestDrive/error.log" -Raw | Out-String)
         } finally {
             $env:DSC_RESOURCE_PATH = $null
             $env:TestDrive = $null

lib/dsc-lib/locales/en-us.toml

@@ -253,7 +253,7 @@ importNoResults = "Extension '%{extension}' returned no results for import"
 secretMultipleLinesReturned = "Extension '%{extension}' returned multiple lines which is not supported for secrets"
 importProcessingOutput = "Processing output from extension '%{extension}'"
 deprecationMessage = "Extension '%{extension}' is deprecated: %{message}"
-failedLoadManifest = "Failed to load manifest '%{path}': %{err}"
+failedLoadManifest = "Extension '%{extension}' failed to load manifest '%{path}': %{err}"
 
 [extensions.extension_manifest]
 extensionManifestSchemaTitle = "Extension manifest schema URI"

lib/dsc-lib/src/discovery/command_discovery.rs

@@ -278,7 +278,7 @@ impl ResourceDiscovery for CommandDiscovery {
                                         // resource that is requested by resource/config operation
                                         // if it is, then "ResouceNotFound" error will be issued later
                                         // and here we just write as info
-                                        info!("{}", t!("discovery.commandDiscovery.failedLoadManifest", path = path.to_string_lossy(), err = e).to_string());
+                                        info!("{}", t!("discovery.commandDiscovery.failedLoadManifest", path = path.to_string_lossy(), err = e));
                                         continue;
                                     },
                                 };

lib/dsc-lib/src/extensions/discover.rs

@@ -102,7 +102,7 @@ impl DscExtension {
                     let manifests = match load_manifest(&discover_result.manifest_path) {
                         Ok(manifests) => manifests,
                         Err(err) => {
-                            info!("{}", t!("extensions.dscextension.failedLoadManifest", path = discover_result.manifest_path.to_string_lossy(), err = err).to_string());
+                            info!("{}", t!("extensions.dscextension.failedLoadManifest", extension = self.type_name, path = discover_result.manifest_path.to_string_lossy(), err = err));
                             continue;
                         }
                     };