Move installation of test modules to bootstrapping

So we can get this working on OneBranch.

Author: andyleejordan

test/PSDesiredStateConfiguration.Tests.ps1

@@ -2,27 +2,6 @@
 # Licensed under the MIT License.
 
 BeforeDiscovery {
-    Function global:Install-ModuleIfMissing {
-        param(
-            [parameter(Mandatory)]
-            [String]
-            $Name,
-            [version]
-            $MinimumVersion,
-            [switch]
-            $SkipPublisherCheck,
-            [switch]
-            $Force
-        )
-
-        $module = Get-Module -Name $Name -ListAvailable -ErrorAction Ignore | Sort-Object -Property Version -Descending | Select-Object -First 1
-
-        if (!$module -or $module.Version -lt $MinimumVersion) {
-            Write-Verbose "Installing module '$Name' ..." -Verbose
-            Install-Module -Name $Name -Force -SkipPublisherCheck:$SkipPublisherCheck.IsPresent
-        }
-    }
-
     Function global:Test-IsInvokeDscResourceEnable {
         return ($PSVersionTable.PSVersion.Major -ge 7)
     }
@@ -87,7 +66,6 @@ Describe "Test PSDesiredStateConfiguration" {
         BeforeAll {
             $origProgress = $global:ProgressPreference
             $global:ProgressPreference = 'SilentlyContinue'
-            Install-ModuleIfMissing -Name PSDscResources
             $testCases = @(
                 @{
                     TestCaseName = 'case mismatch in resource name'
@@ -162,10 +140,6 @@ Describe "Test PSDesiredStateConfiguration" {
             $origProgress = $global:ProgressPreference
             $global:ProgressPreference = 'SilentlyContinue'
 
-            Install-ModuleIfMissing -Name PSDscResources -Force
-
-            # Install PowerShellGet only if PowerShellGet 2.2.1 or newer does not exist
-            Install-ModuleIfMissing -Name PowerShellGet -MinimumVersion '2.2.1'
             $module = Get-Module PowerShellGet -ListAvailable | Sort-Object -Property Version -Descending | Select-Object -First 1
 
             $psGetModuleSpecification = @{ModuleName = $module.Name; ModuleVersion = $module.Version.ToString() }
@@ -273,7 +247,6 @@ Describe "Test PSDesiredStateConfiguration" {
         BeforeAll {
             $origProgress = $global:ProgressPreference
             $global:ProgressPreference = 'SilentlyContinue'
-            Install-ModuleIfMissing -Name XmlContentDsc -Force
             $classTestCases = @(
                 @{
                     TestCaseName = 'Good case'
@@ -340,11 +313,6 @@ Describe "Test PSDesiredStateConfiguration" {
         BeforeAll {
             $origProgress = $global:ProgressPreference
             $global:ProgressPreference = 'SilentlyContinue'
-            $module = Get-InstalledModule -Name PsDscResources -ErrorAction Ignore
-            if ($module) {
-                Write-Verbose "removing PSDscResources, tests will re-install..." -Verbose
-                Uninstall-Module -Name PsDscResources -AllVersions -Force
-            }
         }
 
         AfterAll {
@@ -372,22 +340,14 @@ Describe "Test PSDesiredStateConfiguration" {
                     }
                 )
 
-                Install-ModuleIfMissing -Name PowerShellGet -Force -SkipPublisherCheck -MinimumVersion '2.2.1'
-                Install-ModuleIfMissing -Name xWebAdministration
                 $module = Get-Module PowerShellGet -ListAvailable | Sort-Object -Property Version -Descending | Select-Object -First 1
 
                 $psGetModuleSpecification = @{ModuleName = $module.Name; ModuleVersion = $module.Version.ToString() }
             }
             it "Set method should work" -Skip:(!(Test-IsInvokeDscResourceEnable)) {
-                if (!-not $IsWindows) {
-                    $result = Invoke-DscResource -Name PSModule -ModuleName $psGetModuleSpecification -Method set -Property @{
-                        Name               = 'PsDscResources'
-                        InstallationPolicy = 'Trusted'
-                    }
-                }
-                else {
-                    # workraound because of https://github.com/PowerShell/PowerShellGet/pull/529
-                    Install-ModuleIfMissing -Name PsDscResources -Force
+                $result = Invoke-DscResource -Name PSModule -ModuleName $psGetModuleSpecification -Method set -Property @{
+                    Name               = 'PsDscResources'
+                    InstallationPolicy = 'Trusted'
                 }
 
                 $result.RebootRequired | Should -BeFalse
@@ -443,7 +403,7 @@ Describe "Test PSDesiredStateConfiguration" {
                 $moduleName="TestEmbeddedDSCResource"
                 $embObj = @(New-Object -TypeName psobject -Property @{embclassprop="property1"})
 
-                Install-ModuleIfMissing -Name $moduleName -Force
+                Install-Module -Name $moduleName -Force
 
                 $resource = Get-DscResource -Name $resourceName -Module $moduleName -ErrorAction Stop
                 $resource | Should -Not -BeNullOrEmpty
@@ -515,10 +475,6 @@ Describe "Test PSDesiredStateConfiguration" {
         }
 
         Context "Class Based Resources" {
-            BeforeAll {
-                Install-ModuleIfMissing -Name XmlContentDsc -Force
-            }
-
             AfterAll {
                 $Global:ProgressPreference = $origProgress
             }

test/configuration.Tests.ps1

@@ -8,8 +8,8 @@ Describe "DSC MOF Compilation" {
     }
 
     It "Should be able to compile a MOF using PSModule resource"  {
-        if ($env:GITHUB_ACTIONS -eq 'true') {
-            Set-ItResult -Skipped -Because "Running in GitHub Actions"
+        if ($env:GITHUB_ACTIONS -eq 'true' -or $env:TF_BUILD -eq 'true') {
+            Set-ItResult -Skipped -Because "Does not work in CI"
         }
 
         if (-not $IsWindows) {

tools/installPSResources.ps1

@@ -21,4 +21,16 @@ Install-PSResource -Verbose -TrustRepository -RequiredResource  @{
         version = "5.7.1"
         repository = $PSRepository
     }
+    PSDscResources = @{
+        version = "2.12.0.0"
+        repository = $PSRepository
+    }
+    XmlContentDsc = @{
+        version = "0.0.1"
+        repository = $PSRepository
+    }
+    xWebAdministration = @{
+        version = "3.3.0"
+        repository = $PSRepository
+    }
 }