Use explicit type instead of var

Author: o-l-a-v

src/code/ContainerRegistryServerAPICalls.cs

@@ -1093,7 +1093,7 @@ internal IEnumerable<PSResourceInfo> FindDependencyPackages(
         {
             if (currentPkg.Dependencies.Length > 0)
             {
-                foreach (var dep in currentPkg.Dependencies)
+                foreach (Dependency dep in currentPkg.Dependencies)
                 {
                     PSResourceInfo depPkg = null;
 

src/code/FindHelper.cs

@@ -117,7 +117,7 @@ protected override void BeginProcessing()
         {
             _cancellationTokenSource = new CancellationTokenSource();
 
-            var networkCred = Credential != null ? new NetworkCredential(Credential.UserName, Credential.Password) : null;
+            NetworkCredential networkCred = Credential != null ? new NetworkCredential(Credential.UserName, Credential.Password) : null;
 
             _findHelper = new FindHelper(
                 cancellationToken: _cancellationTokenSource.Token,

src/code/FindPSResource.cs

@@ -44,7 +44,7 @@ public IEnumerable<PSResourceInfo> GetInstalledPackages(
             List<string> pathsToSearch)
         {
             _cmdletPassedIn.WriteDebug("In GetHelper::GetInstalledPackages()");
-            foreach (var pkg in pkgs)
+            foreach (PSResourceInfo pkg in pkgs)
             {
                 // Parse Normalized version if present, if not use Version property of the package
                 NuGetVersion nugetVersion = null;
@@ -69,7 +69,7 @@ public IEnumerable<PSResourceInfo> GetInstalledPackages(
                     includeMaxVersion: true);
 
                 // Search by package name.
-                var foundPkgPaths = FilterPkgPathsByName(
+                List<string> foundPkgPaths = FilterPkgPathsByName(
                     names: new string[] { pkg.Name },
                     pathsToSearch);
 

src/code/GetHelper.cs

@@ -84,7 +84,7 @@ protected override void BeginProcessing()
             if (Path != null)
             {
                 WriteDebug($"Provided path is: '{Path}'");
-                var resolvedPaths = GetResolvedProviderPathFromPSPath(Path, out ProviderInfo provider);
+                System.Collections.ObjectModel.Collection<string> resolvedPaths = GetResolvedProviderPathFromPSPath(Path, out ProviderInfo provider);
                 if (resolvedPaths.Count != 1)
                 {
                     ThrowTerminatingError(new ErrorRecord(

src/code/GetInstalledPSResource.cs

@@ -38,7 +38,7 @@ protected override void EndProcessing()
                     this));
             }
 
-            var resolvedPaths = GetResolvedProviderPathFromPSPath(Path, out ProviderInfo provider);
+            System.Collections.ObjectModel.Collection<string> resolvedPaths = GetResolvedProviderPathFromPSPath(Path, out ProviderInfo provider);
             if (resolvedPaths.Count != 1)
             {
                 ThrowTerminatingError(new ErrorRecord(

src/code/GetPSScriptFileInfo.cs

@@ -42,7 +42,7 @@ public static bool IsGroupPolicyEnabled()
                 return InternalHooks.GPEnabledStatus;
             }
 
-            var values = ReadGPFromRegistry();
+            List<KeyValuePair<string, Uri>>? values = ReadGPFromRegistry();
 
             if (values is not null && values.Count > 0)
             {
@@ -78,11 +78,11 @@ public static bool IsGroupPolicyEnabled()
             {
                 List<Uri> allowedUris = new List<Uri>();
 
-                var allowedRepositories = ReadGPFromRegistry();
+                List<KeyValuePair<string, Uri>>? allowedRepositories = ReadGPFromRegistry();
 
                 if (allowedRepositories is not null && allowedRepositories.Count > 0)
                 {
-                    foreach (var allowedRepository in allowedRepositories)
+                    foreach (KeyValuePair<string, Uri> allowedRepository in allowedRepositories)
                     {
                         allowedUris.Add(allowedRepository.Value);
                     }
@@ -98,7 +98,7 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
 
             if (GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled())
             {
-                var allowedList = GroupPolicyRepositoryEnforcement.GetAllowedRepositoryURIs();
+                Uri[]? allowedList = GroupPolicyRepositoryEnforcement.GetAllowedRepositoryURIs();
 
                 if (allowedList != null && allowedList.Length > 0)
                 {
@@ -117,7 +117,7 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
         {
             List<KeyValuePair<string, Uri>> allowedRepositories = new List<KeyValuePair<string, Uri>>();
 
-            using (var key = Registry.CurrentUser.OpenSubKey(gpRootPath))
+            using (RegistryKey? key = Registry.CurrentUser.OpenSubKey(gpRootPath))
             {
                 if (key is null)
                 {
@@ -138,7 +138,7 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
                         continue;
                     }
 
-                    using (var psrgKey = key.OpenSubKey(subKey + "\\" + psresourcegetGPPath))
+                    using (RegistryKey? psrgKey = key.OpenSubKey(subKey + "\\" + psresourcegetGPPath))
                     {
                         if (psrgKey is null)
                         {
@@ -170,7 +170,7 @@ internal static bool IsRepositoryAllowed(Uri repositoryUri)
                                 }
 
                                 string valueString = value.ToString();
-                                var kvRegValue = ConvertRegValue(valueString);
+                                KeyValuePair<string, Uri> kvRegValue = ConvertRegValue(valueString);
                                 allowedRepositories.Add(kvRegValue);
                             }
                         }

src/code/GroupPolicyRepositoryEnforcement.cs

@@ -257,7 +257,7 @@ private List<PSResourceInfo> ProcessRepositories(
                 return allPkgsInstalled;
             }
 
-            var listOfRepositories = RepositorySettings.Read(repository, out string[] _);
+            List<PSRepositoryInfo> listOfRepositories = RepositorySettings.Read(repository, out string[] _);
             var yesToAll = false;
             var noToAll = false;
 
@@ -866,12 +866,12 @@ private string CreateInstallationTempPath()
 
             try
             {
-                var dir = Directory.CreateDirectory(tempInstallPath);  // should check it gets created properly
-                                                                       // To delete file attributes from the existing ones get the current file attributes first and use AND (&) operator
-                                                                       // with a mask (bitwise complement of desired attributes combination).
-                                                                       // TODO: check the attributes and if it's read only then set it
-                                                                       // attribute may be inherited from the parent
-                                                                       // TODO:  are there Linux accommodations we need to consider here?
+                DirectoryInfo dir = Directory.CreateDirectory(tempInstallPath);  // should check it gets created properly
+                                                                                 // To delete file attributes from the existing ones get the current file attributes first and use AND (&) operator
+                                                                                 // with a mask (bitwise complement of desired attributes combination).
+                                                                                 // TODO: check the attributes and if it's read only then set it
+                                                                                 // attribute may be inherited from the parent
+                                                                                 // TODO:  are there Linux accommodations we need to consider here?
                 dir.Attributes &= ~FileAttributes.ReadOnly;
             }
             catch (Exception e)
@@ -926,7 +926,7 @@ private bool TryInstallToTempPath(
             try
             {
                 var pathToFile = Path.Combine(tempInstallPath, $"{pkgName}.{normalizedPkgVersion}.zip");
-                using var fs = File.Create(pathToFile);
+                using FileStream fs = File.Create(pathToFile);
                 responseStream.Seek(0, System.IO.SeekOrigin.Begin);
                 responseStream.CopyTo(fs);
                 fs.Close();
@@ -1105,7 +1105,7 @@ private bool TrySaveNupkgToTempPath(
             try
             {
                 var pathToFile = Path.Combine(tempInstallPath, $"{pkgName}.{normalizedPkgVersion}.zip");
-                using var fs = File.Create(pathToFile);
+                using FileStream fs = File.Create(pathToFile);
                 responseStream.Seek(0, System.IO.SeekOrigin.Begin);
                 responseStream.CopyTo(fs);
                 fs.Close();
@@ -1419,7 +1419,7 @@ private bool DetectClobber(string pkgName, Hashtable parsedMetadataHashtable, ou
                 }
             }
 
-            foreach (var pkg in pkgsAlreadyInstalled)
+            foreach (PSResourceInfo pkg in pkgsAlreadyInstalled)
             {
                 List<string> duplicateCmdlets = new();
                 List<string> duplicateCmds = new();

src/code/InstallHelper.cs

@@ -270,7 +270,7 @@ protected override void BeginProcessing()
             // Only need to find packages installed if -Reinstall is not passed in
             _packagesOnMachine = Reinstall ? new HashSet<string>(StringComparer.CurrentCultureIgnoreCase) : Utils.GetInstalledPackages(pathsToSearch, this);
 
-            var networkCred = Credential != null ? new NetworkCredential(Credential.UserName, Credential.Password) : null;
+            NetworkCredential networkCred = Credential != null ? new NetworkCredential(Credential.UserName, Credential.Password) : null;
 
             _installHelper = new InstallHelper(cmdletPassedIn: this, networkCredential: networkCred);
         }
@@ -290,7 +290,7 @@ protected override void ProcessRecord()
                     break;
 
                 case InputObjectParameterSet:
-                    foreach (var inputObj in InputObject)
+                    foreach (PSResourceInfo inputObj in InputObject)
                     {
                         string normalizedVersionString = Utils.GetNormalizedVersionString(inputObj.Version.ToString(), inputObj.Prerelease);
                         ProcessInstallHelper(
@@ -468,7 +468,7 @@ private void RequiredResourceHelper(Hashtable reqResourceHash)
                 // Install-PSResource -RequiredResource @ { MyPackage = @{ version = '1.2.3', repository = 'PSGallery' } }
                 if (pkgInstallInfo.Count != 0)
                 {
-                    var pkgParamNames = pkgInstallInfo.Keys;
+                    ICollection pkgParamNames = pkgInstallInfo.Keys;
 
                     foreach (string paramName in pkgParamNames)
                     {
@@ -550,7 +550,7 @@ private void ProcessInstallHelper(string[] pkgNames, string pkgVersion, bool pkg
                     this));
             }
 
-            var installedPkgs = _installHelper.BeginInstallPackages(
+            IEnumerable<PSResourceInfo> installedPkgs = _installHelper.BeginInstallPackages(
                 names: pkgNames,
                 versionRange: versionRange,
                 nugetVersion: nugetVersion,

src/code/InstallPSResource.cs

@@ -19,8 +19,8 @@ public class InternalHooks
 
         public static void SetTestHook(string property, object value)
         {
-            var fieldInfo = typeof(InternalHooks).GetField(property, BindingFlags.Static | BindingFlags.NonPublic);
+            FieldInfo fieldInfo = typeof(InternalHooks).GetField(property, BindingFlags.Static | BindingFlags.NonPublic);
             fieldInfo?.SetValue(null, value);
         }
     }
-}
+}