Add concurrent queue to authenticode check

Author: alerickson

src/code/InstallHelper.cs

@@ -1069,12 +1069,9 @@ private bool TryInstallToTempPath(
                     pkgName,
                     tempDirNameVersion,
                     _cmdletPassedIn,
-                    out string warning,
-                    out error))
+                    errorMsgs,
+                    warningMsgs))
                 {
-                    Utils.EnqueueIfNotNull(warningMsgs, warning);
-                    Utils.EnqueueIfNotNull(errorMsgs, error);
-
                     return false;
                 }
 

src/code/Utils.cs

@@ -2329,16 +2329,13 @@ internal static bool CheckAuthenticodeSignature(
             string pkgName,
             string tempDirNameVersion,
             PSCmdlet cmdletPassedIn,
-            out string warning,
-            out ErrorRecord errorRecord)
+            ConcurrentQueue<ErrorRecord> errorMsgs,
+            ConcurrentQueue<string> warningMsgs)
         {
-            warning = string.Empty;
-            errorRecord = null;
-
             // Because authenticode and catalog verifications are only applicable on Windows, we allow all packages by default to be installed on unix systems.
-            if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
-                warning = "Authenticode check cannot be performed on Linux or MacOS.";
+                warningMsgs.Enqueue("Authenticode check cannot be performed on Linux or MacOS.");
                 return true;
             }
 
@@ -2360,11 +2357,11 @@ internal static bool CheckAuthenticodeSignature(
             }
             catch (Exception e)
             {
-                errorRecord = new ErrorRecord(
+                errorMsgs.Enqueue(new ErrorRecord(
                     new ArgumentException(e.Message),
                     "GetAuthenticodeSignatureError",
                     ErrorCategory.InvalidResult,
-                    cmdletPassedIn);
+                    cmdletPassedIn));
 
                 return false;
             }
@@ -2375,11 +2372,11 @@ internal static bool CheckAuthenticodeSignature(
                 Signature signature = (Signature)signatureObject.BaseObject;
                 if (!signature.Status.Equals(SignatureStatus.Valid))
                 {
-                    errorRecord = new ErrorRecord(
+                    errorMsgs.Enqueue(new ErrorRecord(
                         new ArgumentException($"The signature status for '{pkgName}' file '{Path.GetFileName(signature.Path)}' is '{signature.Status}'. Status message: '{signature.StatusMessage}'"),
                         "GetAuthenticodeSignatureError",
                         ErrorCategory.InvalidResult,
-                        cmdletPassedIn);
+                        cmdletPassedIn));
 
                     return false;
                 }

test/FindPSResourceTests/FindPSResourceRepositorySearching.Tests.ps1

@@ -128,7 +128,7 @@ Describe 'Test Find-PSResource for searching and looping through repositories' -
 
     It "find multiple resources from all repositories where it exists where package Name contains wildcard (without -Repository specified)" {
         $res = Find-PSResource -Name "test_module*" -ErrorVariable err -ErrorAction SilentlyContinue
-        $res | Should -HaveCount 11
+        $res | Should -HaveCount 12
         $err | Should -HaveCount 0
 
         $pkgFoundinLocalRepo = $false