Incorporate code review changes - complete TODOs and remove unneeded key creation

Author: alerickson

src/code/FindHelper.cs

@@ -1289,7 +1289,6 @@ private PSResourceInfo FindDependencyWithSpecificVersion(
             ConcurrentQueue<string> operationVerboseMsgs = new ConcurrentQueue<string>();
 
             // Call FindVersionAsync() for dependency with specific version.
-            string key = $"{dep.Name}|{dep.VersionRange.MaxVersion.ToString()}|{_type}";
             responses = currentServer.FindVersionAsync(dep.Name, dep.VersionRange.MaxVersion.ToString(), _type, operationErrorMsgs, operationWarningMsgs, operationDebugMsgs, operationVerboseMsgs).GetAwaiter().GetResult();
 
             while (operationErrorMsgs.TryDequeue(out ErrorRecord queuedError))
@@ -1344,7 +1343,7 @@ private PSResourceInfo FindDependencyWithSpecificVersion(
 
                     string pkgVersion = FormatPkgVersionString(depPkg);
                     debugMsgs.Enqueue($"Found dependency '{depPkg.Name}' version '{pkgVersion}'");
-                    key = $"{depPkg.Name}{pkgVersion}";
+                    string key = $"{depPkg.Name}{pkgVersion}";
                     if (!depPkgsFound.ContainsKey(key))
                     {
                         // Add pkg to collection of packages found then find dependencies

src/code/V2ServerAPICalls.cs

@@ -1074,7 +1074,6 @@ private string HttpRequestCall(string requestUrlV2, out ErrorRecord errRecord)
         /// </summary>
         private async Task<string> HttpRequestCallAsync(string requestUrlV2, ConcurrentQueue<ErrorRecord> errorMsgs, ConcurrentQueue<string> warningMsgs, ConcurrentQueue<string> debugMsgs, ConcurrentQueue<string> verboseMsgs)
         {
-            // TODO: Async methods cannot have out ref, so currently handling errorRecords as thrown exceptions.
             debugMsgs.Enqueue("In V2ServerAPICalls::HttpRequestCallAsync()");
             string response = string.Empty;
 
@@ -1131,7 +1130,6 @@ private async Task<string> HttpRequestCallAsync(string requestUrlV2, ConcurrentQ
         /// </summary>
         private async Task<HttpContent> HttpRequestCallForContentAsync(string requestUrlV2, ConcurrentQueue<ErrorRecord> errorMsgs, ConcurrentQueue<string> warningMsgs, ConcurrentQueue<string> debugMsgs, ConcurrentQueue<string> verboseMsgs)
         {
-            // TODO: Async methods cannot have out ref, so need to handle errorRecords a different way.
             debugMsgs.Enqueue("In V2ServerAPICalls::HttpRequestCallForContentAsync()");
             HttpContent content = null;
 
@@ -1744,13 +1742,7 @@ public override async Task<FindResults> FindVersionGlobbingAsync(string packageN
                     debugMsgs.Enqueue($"Count is '{count}'");
                     // skip 100
                     skip += 100;
-                    // TODO: this should be an async method
-                    var tmpResponse = FindVersionGlobbing(packageName, versionRange, includePrerelease, type, skip, getOnlyLatest, out ErrorRecord errRecord);
-                    if (errRecord != null)
-                    {
-                        Utils.EnqueueIfNotNull(errorMsgs, errRecord);
-                        return new FindResults(stringResponse: Utils.EmptyStrArray, hashtableResponse: emptyHashResponses, responseType: v2FindResponseType);
-                    }
+                    var tmpResponse = await FindVersionGlobbingAsync(packageName, versionRange, includePrerelease, type, skip, getOnlyLatest, errorMsgs, warningMsgs, debugMsgs, verboseMsgs);
                     responses.Add(tmpResponse);
                     count--;
                 }