Address PR review feedback from Copilot

- Replace Join-String (PS 7+ only) with -join operator for PS 5.1 compat
- Add known switch parameter list to prevent consuming positional args
  after switches like -Force (e.g. 'Install-Module -Force Pester')
- Fix README to document dot-sourcing instead of removed module manifest

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: adityapatwardhan

tool/migration/ConvertTo-PSResourceGet.ps1

@@ -184,7 +184,7 @@ function Find-PSGetCommand {
     )
 
     if ($parseErrors.Count -gt 0) {
-        Write-Warning "Parse errors in '$Path': $($parseErrors | ForEach-Object { $_.Message } | Join-String -Separator '; ')"
+        Write-Warning "Parse errors in '$Path': $(($parseErrors | ForEach-Object { $_.Message }) -join '; ')"
     }
 
     $commandAsts = $ast.FindAll({
@@ -263,10 +263,19 @@ function Convert-PSGetCommand {
             $paramName = $element.ParameterName
             $paramValue = $null
 
+            # Known switch parameters that never take a value argument
+            $switchParams = @(
+                'Force', 'AllowClobber', 'AllowPrerelease', 'AllVersions',
+                'SkipPublisherCheck', 'Reinstall', 'Prerelease',
+                'AcceptLicense', 'NoClobber', 'NoPathUpdate',
+                'PassThru', 'WhatIf', 'Confirm', 'TrustRepository'
+            )
+
             if ($null -ne $element.Argument) {
                 $paramValue = $element.Argument.Extent.Text
             }
-            elseif (($i + 1) -lt $elements.Count -and
+            elseif ($switchParams -notcontains $paramName -and
+                    ($i + 1) -lt $elements.Count -and
                     $elements[$i + 1] -isnot [System.Management.Automation.Language.CommandParameterAst]) {
                 $i++
                 $paramValue = $elements[$i].Extent.Text

tool/migration/README.md

@@ -74,10 +74,11 @@ cmdlets to their [PSResourceGet](https://github.com/PowerShell/PSResourceGet) eq
 
 - `Find-RoleCapability` — No PSResourceGet equivalent. Generates a warning.
 
-## Using as a Module
+## Using as a Script Library
 
 ```powershell
-Import-Module .\tool\migration\PSGetMigration.psd1
+# Dot-source the script to load all functions
+. .\tool\migration\ConvertTo-PSResourceGet.ps1
 
 # Scan a single file
 $results = ConvertTo-PSResourceGetScript -Path .\deploy.ps1

tool/migration/Tests/PSGetMigration.Tests.ps1

@@ -211,6 +211,13 @@ Get-InstalledModule
             $result.ConvertedText | Should -Not -Match '-Force'
         }
 
+        It 'Does not consume positional argument after a switch parameter' {
+            $result = Invoke-ConvertFromScript -Script 'Install-Module -Force Pester'
+            $result.ConvertedText | Should -Match 'Install-PSResource'
+            $result.ConvertedText | Should -Match 'Pester'
+            $result.ConvertedText | Should -Match '-Reinstall'
+        }
+
         It 'Returns NoEquivalent for Find-RoleCapability' {
             $result = Invoke-ConvertFromScript -Script 'Find-RoleCapability -Name MyRole'
             $result.Status | Should -Be 'NoEquivalent'