address PR feedback - use Utils.EmptyStrArray and correct ignore casing

Author: anamnavi

src/code/FindHelper.cs

@@ -1024,7 +1024,7 @@ private IEnumerable<PSResourceInfo> SearchByNames(ServerApiCall currentServer, R
                 foreach (PSResourceInfo currentPkg in parentPkgs)
                 {
                     _cmdletPassedIn.WriteDebug($"Finding dependency packages for '{currentPkg.Name}'");
-                    string[] emptyExternalModuleDependencies = new string[0];
+                    string[] emptyExternalModuleDependencies = Utils.EmptyStrArray;
                     foreach (PSResourceInfo pkgDep in FindDependencyPackages(currentServer, currentResponseUtil, currentPkg, emptyExternalModuleDependencies, repository))
                     {
                         yield return pkgDep;
@@ -1116,7 +1116,7 @@ internal IEnumerable<PSResourceInfo> FindDependencyPackages(
                         continue;
                     }
 
-                    string[] emptyExternalModuleDependencies = new string[0];
+                    string[] emptyExternalModuleDependencies = Utils.EmptyStrArray;
                     if (dep.VersionRange.Equals(VersionRange.All))
                     {
                         FindResults responses = currentServer.FindName(dep.Name, includePrerelease: true, _type, out ErrorRecord errRecord);

src/code/InstallHelper.cs

@@ -1629,8 +1629,8 @@ private bool RetrieveExternalModuleDependenciesForModule(string pkgName, Hashtab
             externalModuleDependencies = Utils.EmptyStrArray;
             List<string> externalModuleDependenciesForPkg = new List<string>();
 
-            Hashtable privateData = moduleMetadata.ContainsKey("PrivateData") ? moduleMetadata["PrivateData"] as Hashtable : new Hashtable(StringComparer.InvariantCultureIgnoreCase);
-            Hashtable psData = privateData.ContainsKey("PSData") ? privateData["PSData"] as Hashtable : new Hashtable(StringComparer.InvariantCultureIgnoreCase);
+            Hashtable privateData = moduleMetadata.ContainsKey("PrivateData") ? moduleMetadata["PrivateData"] as Hashtable : new Hashtable(StringComparer.OrdinalIgnoreCase);
+            Hashtable psData = privateData.ContainsKey("PSData") ? privateData["PSData"] as Hashtable : new Hashtable(StringComparer.OrdinalIgnoreCase);
             object[] externalModDepObjects = psData.ContainsKey("ExternalModuleDependencies") ? psData["ExternalModuleDependencies"] as object[] : new object[0];
             if (externalModDepObjects != null)
             {