Skip to content

Update GitHub Actions to address Node.js 20 deprecation #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into from
Apr 3, 2026
+18 −18
Merged

Update GitHub Actions to address Node.js 20 deprecation #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
DOTNET_GENERATE_ASPNET_CERTIFICATE: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install dotnet
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
cache: true
cache-dependency-path: '**/*.csproj'
Expand All @@ -32,7 +32,7 @@ jobs:
run: ./tools/installPSResources.ps1

- name: Download PowerShell install script
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: PowerShell/PowerShell
path: pwsh
Expand All @@ -45,7 +45,7 @@ jobs:

- name: If debugging, start upterm for interactive pipeline troubleshooting
if: ${{ runner.debug == 1 }}
uses: lhotari/action-upterm@v1
uses: owenthereal/action-upterm@v1
with:
wait-timeout-minutes: 1
Comment on lines 46 to 50
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says owenthereal/action-upterm@v1 is a Node.js 20-based JavaScript action. If that's still true, it won’t actually address the upcoming Node 20 deprecation on GitHub-hosted runners (it may break once Node 20 is removed). Consider switching to an upterm/tmate action release that declares runs.using: node24, or replacing this step with a composite/docker-based alternative that won’t depend on the runner’s Node runtime.

Copilot uses AI. Check for mistakes.

Expand All @@ -55,13 +55,13 @@ jobs:

- name: Upload build artifacts
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: PowerShellEditorServices-module-${{ matrix.os }}
path: module

- name: Upload test results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
if: always()
with:
name: PowerShellEditorServices-test-results-${{ matrix.os }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/close-stale-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
stale-resolved-issues:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
- uses: actions/stale@v10
name: Label resolved issues as needing fix verification
with:
any-of-labels: "Resolution-Answered,Resolution-Duplicate,Resolution-External,Resolution-Fixed,Resolution-Inactive"
Expand All @@ -23,7 +23,7 @@ jobs:
stale-fixed-issues:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
- uses: actions/stale@v10
name: Close issues needing fix verification after 1 week of inactivity
with:
stale-issue-label: "Needs: Fix Verification"
Expand All @@ -34,7 +34,7 @@ jobs:
stale-feedback-issues:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
- uses: actions/stale@v10
name: Close issues needing author feedback after 1 week of inactivity
with:
stale-issue-label: "Needs: Author Feedback"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/emacs-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
DOTNET_GENERATE_ASPNET_CERTIFICATE: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install dotnet
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
cache: true
cache-dependency-path: '**/*.csproj'
Expand All @@ -35,7 +35,7 @@ jobs:
run: Invoke-Build Build

- name: Install Emacs
uses: purcell/setup-emacs@master
uses: purcell/setup-emacs@v8.0
with:
version: '28.2'

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/vim-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
DOTNET_GENERATE_ASPNET_CERTIFICATE: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Install dotnet
uses: actions/setup-dotnet@v4
uses: actions/setup-dotnet@v5
with:
cache: true
cache-dependency-path: '**/*.csproj'
Expand All @@ -41,13 +41,13 @@ jobs:
version: nightly

- name: Checkout vim-ps1
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: PProvost/vim-ps1
path: vim-ps1

- name: Checkout LanguageClient-neovim
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: autozimu/LanguageClient-neovim
path: LanguageClient-neovim
Expand All @@ -57,13 +57,13 @@ jobs:
working-directory: LanguageClient-neovim

- name: Checkout Themis
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: thinca/vim-themis
path: vim-themis

# - name: Debug if run with debugging enabled
# uses: lhotari/action-upterm@v1
# uses: owenthereal/action-upterm@v1

- name: Run Themis with full CLI
env:
Expand Down
Loading