Refactor environment variable setup

Author: vthiebaut10

.pipelines/SecretManagement-Official.yml

@@ -217,9 +217,9 @@ extends:
         - download: current
           displayName: Download artifacts
         - task: CopyFiles@2
-            SourceFolder: $(drop)
-            Contents: Microsoft.PowerShell.SecretManagement.$(version).nupkg
-            TargetFolder: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SrcFiles/
+          SourceFolder: $(drop)
+          Contents: Microsoft.PowerShell.SecretManagement.$(version).nupkg
+          TargetFolder: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SrcFiles/
         - task: ArchiveFiles@2
           inputs:
             rootFolderOrFile: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell/Run
@@ -229,54 +229,25 @@ extends:
             archiveFile: $(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/Shell/Run.tar
           displayName: Compress Run script into tar file as needed for EV2 Shell extension           
         - pwsh: |
-            $pathToJsonFile = Join-Path -Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'SecretManagementToACR.Rollout.json'
+            $pathToJsonFile = '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot/SecretManagementToACR.Rollout.json'
             $content = Get-Content -Path $pathToJsonFile | ConvertFrom-Json
-            $envVarArrayLen = $content.shellExtensions.launch.environmentVariables.Length
 
-            [xml]$xml = Get-Content Directory.Build.props
-            $version = $xml.Project.PropertyGroup.ModuleVersion
+            $environmentVariables = @()
 
-            for ($i=0; $i -lt $envVarArrayLen; $i++)
-            {
-              $name = $($content.shellExtensions.launch.environmentVariables[$i].name)
-              if ($name -eq "DESTINATION_ACR_NAME")
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].value = '$(acr_name)'
-                Write-Verbose -Verbose "ACR Name: $($content.shellExtensions.launch.environmentVariables[$i].value)"
-              }
-              elseif ($name -eq "DESTINATION_ACR_URI")
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].value = '$(acr_uri)'
-                Write-Verbose -Verbose "ACR URI: $($content.shellExtensions.launch.environmentVariables[$i].value)"
-              }
-              elseif ($name -eq "MI_NAME")
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].value = '$(managed_identity_name)'
-                Write-Verbose -Verbose "MI Name: $($content.shellExtensions.launch.environmentVariables[$i].value)"
-              }
-              elseif ($name -eq "MI_CLIENTID")
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].value = '$(managed_identity_clientid)'
-                Write-Verbose -Verbose "MI Client ID: $($content.shellExtensions.launch.environmentVariables[$i].value)"
-              } 
-              elseif($name -eq "SECRET_MANAGEMENT_VERSION") 
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].value = $version
-                Write-Verbose -Verbose "Module version: $($content.shellExtensions.launch.environmentVariables[$i].value)"
-              }
-              elseif($name -eq "SECRET_MANAGEMENT_MODULE") 
-              {
-                $content.shellExtensions.launch.environmentVariables[$i].reference.path = "SrcFiles\\Microsoft.PowerShell.SecretManagement.$(version).nupkg"
-                Write-Verbose -Verbose "Module Path: $($content.shellExtensions.launch.environmentVariables[$i].reference.path)"
-              }
-            }
+            $environmentVariables += [PSCustomObject]@{name="DESTINATION_ACR_NAME", value='$(acr_name)'}
+            $environmentVariables += [PSCustomObject]@{name="DESTINATION_ACR_URI", value='$(acr_uri)'}
+            $environmentVariables += [PSCustomObject]@{name="MI_NAME", value='$(managed_identity_name)'}
+            $environmentVariables += [PSCustomObject]@{name="MI_CLIENTID", value='$(managed_identity_clientid)'}
+            $environmentVariables += [PSCustomObject]@{name="SECRET_MANAGEMENT_VERSION", value='$(version)'}
+            $environmentVariables += [PSCustomObject]@{name="SECRET_MANAGEMENT_MODULE", reference=[PSCustomObject]@{path="SrcFiles\\Microsoft.PowerShell.SecretManagement.$(version).nupkg"}'}
+
+            $content.shellExtensions.launch.environmentVariables = $environmentVariables
 
             $identityString = "/subscriptions/$(acr_subscription)/resourcegroups/$(acr_resource_group)/providers/Microsoft.ManagedIdentity/userAssignedIdentities/$(managed_identity_name)" 
             $content.shellExtensions.launch.identity.userAssignedIdentities[0] = $identityString
 
             Remove-Item -Path $pathToJsonFile
             $content | ConvertTo-Json -Depth 6 | Out-File $pathToJsonFile
-
           displayName: 'Replace values in SecretManagementToACR.Rollout.json file'
         - pwsh: |
             $pathToJsonFile = Join-Path -Path '$(Build.SourcesDirectory)/EV2Specs/ServiceGroupRoot' -ChildPath 'RolloutSpec.json'